884772 - Article histories don't validate

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[Scoobidiver (away)]

There are 12 errors for the chosen example!

See http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.mozilla.org%2Fen-US%2Fkb%2Fhow-to-enable-java-if-its-been-blocked%2Fhistory&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.3+http%3A%2F%2Fvalidator.w3.org%2Fservices

Comment 1

[Alejandro López Espinosa]

Hi,
The async error is due to the difference in syntax between the html5 spec [1] and the real implementation of some browsers that need the attribute to be true or false, so i don't know what to do, wheter to make it html5 compilant or to leave it like it is and protect legacy browsers. I suppose that the latter is the most important thing.
I have made a pull request with the noindex attribute deleted (it can only be in the robots meta tag): https://github.com/mozilla/kitsune/pull/1778
bye

[1] http://www.w3.org/html/wg/drafts/html/master/scripting-1.html#async

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/cbd70843a696aca92ca6925c2937f8da22f94e8e


This won't get deployed to production until the new year because we have frozen our prod systems until then.


Thanks!!!

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now!