884782 - Fill in details in AAQ doesn't validate

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P4)

Description

[Scoobidiver (away)]

There are 2 errors.

See http://validator.w3.org/check?uri=https%3A%2F%2Fsupport.mozilla.org%2Fen-US%2Fquestions%2Fnew%2Fdesktop%2Ffix-problems%2Fform%3Fsearch%3DFirefox%2Bcrashes%26step%3Daaq-question&charset=%28detect+automatically%29&doctype=Inline&group=0&user-agent=W3C_Validator%2F1.3+http%3A%2F%2Fvalidator.w3.org%2Fservices

Comment 1

[Beatriz]

Hi,

I'm interested in working on this issue. Could you please assign it to me?

Thanks

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Beatriz from comment #1)
> Hi,
> 
> I'm interested in working on this issue. Could you please assign it to me?
> 
> Thanks

Let us know if you have any questions!

Comment 3

[Beatriz]

Thanks! I've just made a pull request with the required changes.

Comment 4

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Can you provide the link to the pull request?

Comment 5

[Beatriz]

Here is it https://github.com/mozilla/kitsune/pull/1769

I'm having some doubts about what to put in the form action field. I've tried with '#' and it works, but I wonder if there is a better solution. Any insight?

Comment 6

[Beatriz]

I've just found out that we can leave out the action attribute. It validates and the form submits to the current url + parameters

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Beatriz from comment #6)
> I've just found out that we can leave out the action attribute. It validates
> and the form submits to the current url + parameters

That's OK with me!

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/compare/65d78e0cf756...1cf8257cf515

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now. Thanks!