884865 - Suggestion: Use full area of high resolution icon for displaying icons in home screen instead of wrapping icon in a button

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Soledad Penades [:sole] [:spenades]]

This will make shortcuts blend nicely with the rest of icons, and make better use of the provided high resolution icons where present.

Current favicon-in-a-button style could be still used when the website doesn't provide a high resolution icon.

Comment 1

[Aaron]

Do you have a screenshot of how it current looks?

Comment 2

[Soledad Penades [:sole] [:spenades]]

It was for another bug, but here's more or less how they look currently in different versions: https://bug884848.bugzilla.mozilla.org/attachment.cgi?id=764781

Comment 3

[Aaron]

Hmm not sure what the issue is.  I created a transparent .png for the homescreen/launcher icon.  It seems to be adding in a background behind the icon?  

Here's some documentation:
http://developer.android.com/design/style/iconography.html#launcher

Comment 4

[Soledad Penades [:sole] [:spenades]]

Yes, it currently adds a background i.e. puts the provided icon in a button. My suggestion is to stop doing that, and use the app-provided icon without further modifications.

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch

You ok with this mfinkle? I thought at one point we wanted to emphasize these are "bookmarks" and not "apps", but I could be remembering wrong.

We should use apple-touch-icon as well, but that will require more work updating our favicon db to handle storing multiple icons (or at least the urls for multiple icons) for a single site.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 767841 [details] [diff] [review]
Patch

The patch itself looks fine, but I think we need get Ian to buy into this idea. Some screenshots showing the difference might be useful.

Comment 7

[Ian Barlow (:ibarlow)]

(In reply to Wesley Johnston (:wesj) from comment #5)
> Created attachment 767841 [details] [diff] [review]
> Patch
> 
> You ok with this mfinkle? I thought at one point we wanted to emphasize
> these are "bookmarks" and not "apps", but I could be remembering wrong.
> 

I remember that too, but I think I'm less concerned about that than I once was. If we can get bigger and better looking icons, we should.

Some screenshots would be nice, though.

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b97d49ba331

Comment 9

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df9231393766

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b97d49ba331