884899 - [B2G][Leo][Calendar] Alarm icon for events created does not appear in week view

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Sarah Parsons]

Description:
Alarm icon for events created does not appear in week view. 

Repro Steps:
1) Updated to Leo Build ID: 20130610070206
2) Open the Calendar App.
3) Create an event with a single alarm.
4) Once event is created, notice in month view an alarm icon appears. 
5) Go to day view and an alarm icon appears too on the event.
6) Go to week view, alarm icon does not appear on the event. 

Actual:
There is no alarm icon on events in week view.

Expected:
An alarm icon should appear in the week view to remain consistant with the day and month views.

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

Notes:
Repro frequency: 100%
Test Suite Name: calendar
UCID: calendar-051

Comment 1

[Sarah Parsons]

Attachment: missing alarm icon in week view

Comment 2

[Leo]

ni for your comments on this.

Comment 3

[Jason Smith [:jsmith]]

Makes sense to do, but probably isn't critical enough to hold the release on.

Comment 4

[James Lal [:lightsofapollo]]

We would accept a patch for this (its probably a trivial few lines of css)

Comment 5

[Mark Shiao]

Attachment: redirec to pull request

Comment 6

[Mark Shiao]

Attachment: redirect to pull request

Hi James,

This patch adds the alarm bell icon to the week view.  I would also like to raise a few issue with this implementation:
1) The icon is had to read against the orange background
2) The week view real estate is quite small and my implementation seems to waste a lot of it.

Perhaps we need to get UX involved? Let me know what you think.

Thanks,
Mark

Comment 7

[James Lal [:lightsofapollo]]

Probably good question for Rob-

Comment 8

[Mark Shiao]

Attachment: calendar week screenshot

Screenshot for reference

Comment 9

[James Lal [:lightsofapollo]]

Comment on attachment 770054 [details]
redirect to pull request

Making it clear we need UX help before moving forward... From a code perspective this looks good but I am not really sure about adding this big alarm icon everywhere.

Comment 10

[Rob MacDonald [:robmac]]

Although showing the alarm icon is consistent, using the same icon as the day and month views is problematic because 1) the icon is too large for the container and 2) the icon is running into the text. 

I propose that, in week view, we replace the current alarm icon with something that is smaller and slightly simpler. In addition, rather than having the icon on the top right of the event container, the icon should move to the bottom right corner of the container. I've added a needsinfo for Przemek to provide us with direction on the visual design.

Until we have this, I'd prefer to remove the icon entirely, even if it is inconsistent. 

Please flag me if you have any questions. And, Przemek, feel free to reach out over IRC.

Rob

Comment 11

[Rob MacDonald [:robmac]]

Comment on attachment 770054 [details]
redirect to pull request

Please see comment 10, which is based on of Mark's attachment (2013-07-04-18-35-26.png)

Comment 12

[Rob MacDonald [:robmac]]

I talked to Przemek and, after reviewing a few ideas, we felt it was best to actually leave the icon out of the week view, as per the current implementation. With the amount of available space, the icon simply doesn't fit without severely truncating the text, which we felt was more important in this case.

Comment 13

[Mark Shiao]

Based on Rob's comments there no work to be done here so going to mark this resolved.  Please feel free to reopen if you have any other concerns.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Mark Shiao from comment #13)
> Based on Rob's comments there no work to be done here so going to mark this
> resolved.  Please feel free to reopen if you have any other concerns.

Should be WONTFIX then, not FIXED.

Comment 15

[Jason Smith [:jsmith]]

Discussed this offline with a few folks - going to disagree with UX's call here. Google Calendar does make use of an alarm icon on their UX in the week view, so we should be able to find an avenue here that should make it possible to show the alarm icon on the week view without causing text overlap. I think VD needs to think about this a bit more in their design here - if you can't place the alarm icon next to the text, consider putting the icon below the title.

======

DESCRIPTION GOES HERE


<icon>
======

Comment 16

[Stephany Wilkes]

I am removing the flag for UX. Rob has already commented at length and we have nothing new to add.

Comment 17

[Jason Smith [:jsmith]]

(In reply to Stephany Wilkes from comment #16)
> I am removing the flag for UX. Rob has already commented at length and we
> have nothing new to add.

I think QA has made it clear that we're not in agreement here. Re-adding needinfo to address the concerns brought up in comment 15.

Comment 18

[Stephany Wilkes]

I am no longer sure what a UX flag means if both Rob (IxD) and Przemek (VxD) in collaboration don't have enough combined expertise to make a call here. Mark's comment #13 is appropriate. 

There have been several bugs on which UX is essentially flagged repeatedly until we agree with an approach others desire, even if that approach does not fit with our recommendation, which our team took time to make. Putting an icon below the title is not an acceptable system wide pattern, and I'm not sure what relevance Google Calendar has here. 

There are many improvements to layout and truncation forthcoming. UX is making myriad ad hoc visual adjustments for L10N for 1.2 (until Eric Pang's suggestions for more comprehensive solutions can make it into the BB), and the BB are changing in both 1.3 (see bug #925925) and 1.4.

Comment 19

[Jason Smith [:jsmith]]

(In reply to Stephany Wilkes from comment #18)
> I am no longer sure what a UX flag means if both Rob (IxD) and Przemek (VxD)
> in collaboration don't have enough combined expertise to make a call here.
> Mark's comment #13 is appropriate. 

Making a call here doesn't necessarily conclude a bug's workflow. If you aren't answering the right questions on the bug, then people reopen the bug due to outstanding questions. comment 12 fails to address the reporter's needs here - it doesn't explain with an appropriate reasoning why an inconsistent design makes sense here. This was discussed offline with some of the QA team members, which warranted the bug to be reopened due to missing data. I don't think you've answered the questions appropriately here at all.

> 
> There have been several bugs on which UX is essentially flagged repeatedly
> until we agree with an approach others desire, even if that approach does
> not fit with our recommendation, which our team took time to make. Putting
> an icon below the title is not an acceptable system wide pattern, and I'm
> not sure what relevance Google Calendar has here. 

The relevance of a system wide argument has no applicability here. This is an app-specific issue. 

> 
> There are many improvements to layout and truncation forthcoming. UX is
> making myriad ad hoc visual adjustments for L10N for 1.2 (until Eric Pang's
> suggestions for more comprehensive solutions can make it into the BB), and
> the BB are changing in both 1.3 (see bug #925925) and 1.4.

That's not really relevant to this discussion.

Comment 20

[Stephany Wilkes]

Flagging Rob so he and QA can discuss with the more "appropriate reasoning" required of him.

Comment 21

[Jason Smith [:jsmith]]

Rob & I had a private chat on this. To really fix the root cause here, we need to overhaul the week view design to allow for usage of icons on the week view. The current design won't work to support this since we don't have the real estate. What we'll do here is add an item to the productivity backlog to do a week view redesign that ensures that we consider the alarm icon use case as part of thinking about the redesign. I'll email Peter privately to add the week view redesign to the productivity backlog.

Comment 22

[John Hammink]

moving to permafail, even though it's a no-fix.  Will help clean up queries.