884931 - signmar should output the gecko version in its usage and/or --version

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

MOZ_APP_VERSION is already available - if that's the thing to use, I can provide a patch for this.

Comment 1

[Brian R. Bondy [:bbondy]]

Yes that sounds like a good idea, I'd recommend using MOZ_APP_VERSION because that's what it signs mars with by default. I can review it if you do such a patch. 

The command line parsing is really primitive in it, so to simplify things, please just print it in the print_usage function.

Comment 2

[Brian R. Bondy [:bbondy]]

Version: x (MOZ_APP_VERSION)
Default channel ID: z (MAR_CHANNEL_ID)

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug894931.diff

Yay, my first patch to m-c (so I'll need to figure out how/where to land it).

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 790468 [details] [diff] [review]
bug894931.diff

Review of attachment 790468 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks for the patch.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67d3e9da1b4b

\o/

For future reference, please make sure you configure Hg to generate patches with the necessary commit information to make life easier on your humble sheriffs. Thanks :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67d3e9da1b4b