884937 - Make it easier to run multilocale builds

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Anthony Ricaud (:rik)]

Running a multilocale Gaia should be as easy as:
|make install-locale pt-BR|
|make install-locale es|
|make install-gaia|

The install-locale target would do all the necessary things in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Building#Building_multilocale

Comment 1

[Anthony Ricaud (:rik)]

I discovered |make multilocale-clean|. One improvement over the current situation would be to run this after pushing to the phone.

Comment 2

[Fabien Cazenave [:kaze]]

|make multilocale-clean| will override the real changes on manifest files (if any).

The rest of the build magic (e.g. webapp-optimize.js, webapp-zip.js) doesn’t leave any temporary file in the source tree, we could probably have a similar approach for adding locales. Otherwise, maybe an objdir would do the job.

Comment 3

[Staś Małolepszy :stas]

Objdir would be great to have, I agree.  Setting the dependency on bug 815187.

I'd like to have the hg-pull logic in those make targets, like comment 0 suggests.  However, I'm not sure having to run install-locale for every desired locale is the way to go.  I think I prefer the current approach which uses a config file in locales/.

Anthony, what do you think?

Comment 4

[Staś Małolepszy :stas]

(In reply to Staś Małolepszy :stas from comment #3)
> I'd like to have the hg-pull logic in those make targets, like comment 0
> suggests.  However, I'm not sure having to run install-locale for every
> desired locale is the way to go.  I think I prefer the current approach
> which uses a config file in locales/.

Just to elaborate on the 'why':  these scripts are mostly run by releng's buildbots and keeping the list of locales in conf files is easier for them.  As in, they'd need to do it anyways.

But, maybe we could go for a combined approach, so that installing individual locales is easier for developers.

Comment 5

[Anthony Ricaud (:rik)]

I'm not suggesting we get rid of the config file in the locales/ directory. The way I imagine it, |make install-locale pt-BR| is just a shortcut on top of the current setup. It would just automate what the documentation suggests. It wouldn't push to the phone. Maybe install-locale is a bad name btw, setup-locale or add-locale maybe.

Comment 6

[Fabien Cazenave [:kaze]]

We’ve just landed bug 853933 which creates a /locales-obj/ directory for each app. Instead of duplicating the whole Gaia tree into an objdir, we could probably use this /locales-obj/ dir to store the modified manifests and other l10n-specific files before processing them into a ZIP archive.

Comment 7

[BMO Automation]

Firefox OS is not being worked on