884956 - CallArgsify jsmath.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

The static analysis would like us to Handlify ToNumber. This is easy except for the large number of users in jsmath.cpp that call ToNumber with vp[0]. This series of patches contains simple cleanups and CallArgsification of jsmath.cpp so that we can use args.handleAt(0) instead.

Comment 1

[Terrence Cole [:terrence]]

Attachment: Part 1 of 6 - Rename JS_TRUE/JS_FALSE to true/false; v0

Comment 2

[Terrence Cole [:terrence]]

Attachment: Part 2 of 6 - Add CallArgs decls where needed; v0

Comment 3

[Terrence Cole [:terrence]]

Attachment: Part 3 of 6: Rename argc to args.length(); v0

Comment 4

[Terrence Cole [:terrence]]

Attachment: Part 4 of 6 - Rename vp[2+] to args[0+]

Comment 5

[Terrence Cole [:terrence]]

Attachment: Part 5 of 6 - Use rval() instead of vp->

Comment 6

[Terrence Cole [:terrence]]

Attachment: Part 6 of 6 - Everything non-sed

Comment 7

[Jeff Walden [:Waldo]]

Comment on attachment 764921 [details] [diff] [review]
Part 6 of 6 - Everything non-sed

Review of attachment 764921 [details] [diff] [review]:
-----------------------------------------------------------------

Well, those were all nice and speedy.  Not sure if the super-breakup helped the overall time or not, but it definitely helped with each part being quick!

Comment 8

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13d534ef657b

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/13d534ef657b