We want to ship Firefox Mobile with a good list of search engines for Swedish. We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Hasse, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>. For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives: > Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon) Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Hasse, we'll likely need your help to at least get the contact information. For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>. Once we have a specification on what the search engines for Swedish should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Hasse, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing. Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here. The Swedish team and Milos will be driving this bug to completion.
Please note that we are aiming to include this into Firefox 24, which means that we have until August 5th.
Created attachment 766814 [details] [diff] [review] patch We would like to replace Amazon with Prisjakt, which we already use in desktop Firefox. So the set of plugins for Swedish would be: Google Prisjakt Twitter Wikipedia (sv) The permission to use Prisjakt can be found in bug 415837, comment #3. I have adapted the Prisjakt plugin for mobile use by removing the description element, and switching to a 32x32 icon. The Wikipedia plugin is already in Swedish, see bug 758853.
Attachment #766814 - Flags: review?(milos)
Attachment #766814 - Flags: review?(milos) → review-
(In reply to Hasse from comment #2) > Created attachment 766814 [details] [diff] [review] > patch > > We would like to replace Amazon with Prisjakt, which we already use in > desktop Firefox. So the set of plugins for Swedish would be: > Google > Prisjakt > Twitter > Wikipedia (sv) > > The permission to use Prisjakt can be found in bug 415837, comment #3. > > I have adapted the Prisjakt plugin for mobile use by removing the > description element, and switching to a 32x32 icon. > > The Wikipedia plugin is already in Swedish, see bug 758853. Hasse, Since we're getting close to the migration day, would you and the Swedish team be interested in shipping without Prisjakt for the time being and adding it once you've received a response from them? If so, we have only a few days to reflect this in your Aurora repo, sign-off, and add it to the multi-locale build. Let me know what you'd like to do. Jeff
Yes, it doesn't look like we will have Prisjakt ready for Firefox 24. I am willing to go with what we have for now, and replace Amazon in the next release. Apart from that issue, our Aurora repo is ready with no further work needed. So if it's OK with you, I can sign-off now.
(In reply to Hasse from comment #5) > Yes, it doesn't look like we will have Prisjakt ready for Firefox 24. I am > willing to go with what we have for now, and replace Amazon in the next > release. > > Apart from that issue, our Aurora repo is ready with no further work needed. > So if it's OK with you, I can sign-off now. Go ahead. I'll do the review once you've signed off. Thank you!
I'd prefer to remove amazon now, and add prisjakt later. That's doing less surprises to users.
Created attachment 783829 [details] [diff] [review] patch to remove Amazon Good point. Here is a patch to do that. I will probably sign-off tomorrow instead.
Comment on attachment 783829 [details] [diff] [review] patch to remove Amazon Review of attachment 783829 [details] [diff] [review]: ----------------------------------------------------------------- Sweet, exactly. Great commit message, too.
Attachment #783829 - Flags: review?(l10n) → review+
In order to close this bugs as it relates to releasing Fennec with Firefox 24, please file a new bug to have Prisjakt added to your search plugins, CC-ing those of us that are on this bug, once you've heard from Prisjakt. Closing bug now.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.