If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[sv-SE] Search engine setup for Firefox Mobile for Swedish

RESOLVED FIXED

Status

Mozilla Localizations
sv-SE / Swedish
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gueroJeff, Assigned: u60234)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

558 bytes, patch
Pike
: review+
Details | Diff | Splinter Review
(Reporter)

Description

4 years ago
We want to ship Firefox Mobile with a good list of search engines for Swedish.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Hasse, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Hasse, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Once we have a specification on what the search engines for Swedish should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Hasse, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Swedish team and Milos will be driving this bug to completion.
(Reporter)

Updated

4 years ago
Blocks: 626023
(Reporter)

Comment 1

4 years ago
Please note that we are aiming to include this into Firefox 24, which means that we have until August 5th.
(Assignee)

Comment 2

4 years ago
Created attachment 766814 [details] [diff] [review]
patch

We would like to replace Amazon with Prisjakt, which we already use in desktop Firefox. So the set of plugins for Swedish would be:
Google
Prisjakt
Twitter
Wikipedia (sv)

The permission to use Prisjakt can be found in bug 415837, comment #3.

I have adapted the Prisjakt plugin for mobile use by removing the description element, and switching to a 32x32 icon.

The Wikipedia plugin is already in Swedish, see bug 758853.
Attachment #766814 - Flags: review?(milos)

Comment 3

4 years ago
Comment on attachment 766814 [details] [diff] [review]
patch

Review of attachment 766814 [details] [diff] [review]:
-----------------------------------------------------------------

r-, please read below:

::: mobile/searchplugins/prisjakt-sv-SE.xml
@@ +5,5 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Prisjakt</ShortName>
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAIAAAD8GO2jAAAABnRSTlMA/wD/AP83WBt9AAAACXBIWXMAAA7EAAAOxAGVKw4bAAAGmUlEQVR42q1Wy2/dRxX+5szM73l9H76Oaztum4jE5lFLJqIV0CWLSohNUdV1Jf4F9pH3rFh3CSyiSJGQAAlaKgUkWlCFVZpn3Zgm14/4cd+/1zxZXGOnbpwGibOcOfN9Z46+M/Mx7z3Ojs7aGoBiff2pu/HqKoDFq1efgcDOIuisrdH1a/tJei7P8HXh3nr7LJqnEEygAXTH2XQt3XVQSlWVrqpqVFTjQiljGGxIXggRG/3at78JILu0FK+ufpVGnIUOgKzd6Q1y57WxlbGF0bnWihknjSRnDJSyBNz79PaLadIg6h8edr7SMXEKvfv7PwhGxmjnKQ/jIi/yQpVllStdwfLI1ZouTgFQkflx3/dLGMbLogru3J0Ownh39xSHOFX7DLBXlD3tSkd5ZYuszPJyDD2EsbDnBS5fwswsGwzowSYd7PshEHlMe5s4eG1eOOj6X//mSY4TgklnHueFEoEydjzOijxXOq9gK6AEAKQzeP0XPwTw8N2PtnqwO14VXsJ7MA7KYTf6vXZZRe+9f8whTsoHutb2jVPWDAqVm0xEWatt2wl0QBkjztjFizTJby7KlzNHKfLKh8LFjuxY6D22vW9cMX6lN+j9V9lHKtpe+U5MrGPN9lCNRmVmsqBWzMzp+UXU2kQxP//Oq8+Q6e77/9jd8Luf+N5ntjXkl2qNqQtzE+2K4/IL5zOls9KM8pzCfHrWLC7T/OVw6iff/do5mPvRq2Xx9/4WfEeOhrQ9Hi5jbjKe4rj7APK8ykZVqav2tJlfxMJyVPvx6mSr99tP8l4lp/jsT68AeHTjn8PHBh61Nnv57e8BKIfeGxAjA16AAKQb9ztra2JSPoB7h71xofOqNN6EERrn+An6B5/vbarhnp6a07MAgK07Veeusx5xA59+/DeSzCmvDslrxgWHFE+RqbOmKJXymsHJkIUNCYD70rKozHzeNUUfcf0oebDjDr6A5RB9VNob4zkhZD5SvhFQkkQnBMX6egoAMNYpox1MFCCoc9EIAViK4IF6Gi1UfMqkLxwda11MFPNWMhaiGLrxnhnu23EBEJopiUhO0or19ZMblMYarwErEgRNIackAA9elJRebsXtgGvDg6PkpTfOXbLMSWLS25E6vJX/68/Zo9tGOebALaentKgyRsFpwHHICLWa5+oAzXYtCdhMhFJAeVhmnCHp21faCBmIIBzyqhFS53a1dcc4T44LR2zL6PNCAjih0lpp5xWD0vDacqcef7gPnzOWg0pw4wVZKXggSEoghk2gI1SxzetFFSpNznsCcSmInnYDZg0HnGejod/6t3vvRr7yRn3/o67xguB4RK3leQC9+32jiIIgnI6SJjwkg+vvI8u8BSKGULJAECd+mkBaF4EFYBmw8QCzuev2R1G9VIo5g4Ul8YPleQCPbm4PD2j6Qn3+ShvNkEEDKLq6HDvHIIhFgkWCSy7h7JcILMCBuiQpnfJ+b8/3uiYITDWGt4j4UUWDjX53h8eJJHYyyWqgdG69J+JcchKMSSlRWQAiXl3Fxn0AJTHrUJ9m5+cYC5FVPq9gLIRExNCcPsKTEU8aIp4Og2YMuCMFjo1TnkMIEYCEd2BEk0/7iefa+QosbOCly3jl59+fLH787odqyEJGMxeSycrCSssUsrVcD1tH6Js3+4ODwlaIKAjCiJPg1umqOnlNP3vzzXTjPoDf3brb+BatvI6ln72G5wjuk4PN/u0/Pnzwl4P+Nk9Eq91ovDgVtJxJJc8uLV2+cYOO3QeA1Hs9soOuP7h553kIOje3Hv11e+fWYHTgBUXNWlQPKRWUSn4Me/IfcEuWuz9t3G5e5PGsIGEy5ypHaS146RvpxZVmvDIL4INfbnY6Jdc+AaBMMdLDnndF0Egbs2mSwJ+rJ3VjJuWfqMi99TauXwMwW1J213bv+cxhD34MO1NTLqNWK4hXAODWzd7dTpkA02ASCIWIk9pUkjaSuCl4QuBhCGOOu3JEsHj1ageg69eWGq3PB4dj7whMIAzheOWLgX78YDD+1Z0vHpispzggISVkJEQaB42pWj2QkvmA+bbgyLInfdiXjNexKdq8d79wvOd5Bi8abmrBJU3nHfpdOjzgKg9rYTSVBJEUqaSaDFIhPCMKg1aRnXJ5p53difHa2dvtD3pERUw+ZVZ4ZZixgiiKeVyLwkgy4X3qbEo8lOIsD/ks6wjgYbdnZFRWOtNWM+KCx2FQi2QUygVnAPS4aFnzDId6pvk9Ho7nif/N/P5/7ft/AM59zm8+8EypAAAAAElFTkSuQmCC</Image>
> +<Url type="text/html" method="GET" template="http://www.prisjakt.nu/supersearch.php">

This redirects to http://www.prisjakt.nu/search.php. Somewhere in the middle, we lose parameters "e" and "ref"(URL looks something like "http://www.prisjakt.nu/search.php?s=foobar&r=1" after searching. Would you please email administrators and see if we're losing those parameters because we're sending them to a wrong search page, or it's handle somewhere in redirect. As in, do we still want to use the same(old) url for search queries, or do we want same parameters sent to http://www.prisjakt.nu/search.php instead?

One other thing about this is that their website doesn't do mobile vs. desktop detection, meaning that this searchplugin will always show desktop website with search results, even for mobile users, and we don't want that as they do actually have mobile version of the website. That said, we do want to show desktop version for users on tablets, so we'd want to use type parameter for <URL> elements that were introduced in bug 861164.

Now, I know all this can be daunting, so I propose I create a patch for you once you get an aswer from Prisjakt team on the matter I described in first paragraph in this review.

@@ +11,5 @@
> +  <Param name="r" value="1"/>
> +  <Param name="e" value="utf8"/>
> +  <Param name="ref" value="155"/>
> +</Url>
> +<Url type="application/x-suggestions+json" method="GET" template="http://www.prisjakt.nu/plugins/opensearch/suggestions.php?search={searchTerms}">

When you're writing to Prisjakt team, please ask them if there's a different url we can use for fetching results for mobile users.
Attachment #766814 - Flags: review?(milos) → review-
(Reporter)

Comment 4

4 years ago
(In reply to Hasse from comment #2)
> Created attachment 766814 [details] [diff] [review]
> patch
> 
> We would like to replace Amazon with Prisjakt, which we already use in
> desktop Firefox. So the set of plugins for Swedish would be:
> Google
> Prisjakt
> Twitter
> Wikipedia (sv)
> 
> The permission to use Prisjakt can be found in bug 415837, comment #3.
> 
> I have adapted the Prisjakt plugin for mobile use by removing the
> description element, and switching to a 32x32 icon.
> 
> The Wikipedia plugin is already in Swedish, see bug 758853.

Hasse,

Since we're getting close to the migration day, would you and the Swedish team be interested in shipping without Prisjakt for the time being and adding it once you've received a response from them? If so, we have only a few days to reflect this in your Aurora repo, sign-off, and add it to the multi-locale build. Let me know what you'd like to do.

Jeff
(Assignee)

Comment 5

4 years ago
Yes, it doesn't look like we will have Prisjakt ready for Firefox 24. I am willing to go with what we have for now, and replace Amazon in the next release.

Apart from that issue, our Aurora repo is ready with no further work needed. So if it's OK with you, I can sign-off now.
(Reporter)

Comment 6

4 years ago
(In reply to Hasse from comment #5)
> Yes, it doesn't look like we will have Prisjakt ready for Firefox 24. I am
> willing to go with what we have for now, and replace Amazon in the next
> release.
> 
> Apart from that issue, our Aurora repo is ready with no further work needed.
> So if it's OK with you, I can sign-off now.

Go ahead. I'll do the review once you've signed off.

Thank you!

Comment 7

4 years ago
I'd prefer to remove amazon now, and add prisjakt later. That's doing less surprises to users.
(Assignee)

Comment 8

4 years ago
Created attachment 783829 [details] [diff] [review]
patch to remove Amazon

Good point. Here is a patch to do that. I will probably sign-off tomorrow instead.
Attachment #766814 - Attachment is obsolete: true
Attachment #783829 - Flags: review?(l10n)

Comment 9

4 years ago
Comment on attachment 783829 [details] [diff] [review]
patch to remove Amazon

Review of attachment 783829 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet, exactly. Great commit message, too.
Attachment #783829 - Flags: review?(l10n) → review+
(Assignee)

Comment 10

4 years ago
Checked in attachment 783829 [details] [diff] [review].
http://hg.mozilla.org/l10n-central/sv-SE/rev/e81fe9136a4c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sv-SE/rev/a18d512d2196
(Reporter)

Comment 11

4 years ago
In order to close this bugs as it relates to releasing Fennec with Firefox 24, please file a new bug to have Prisjakt added to your search plugins, CC-ing those of us that are on this bug, once you've heard from Prisjakt.

Closing bug now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 907301
You need to log in before you can comment on or make changes to this bug.