884987 - NSPR DragonFly platform support

Status: NEW

(NSPR :: NSPR, defect)

Description

[François Tigeot]

Until now, the freebsd platform files have been used to build nspr on DragonFly but this is not ideal.
It would be better to handle DragonFly as a separate platform like it is done with most operating systems.

Comment 1

[François Tigeot]

Attachment: DragonFly-specific platform file

Comment 2

[François Tigeot]

Attachment: DragonFly-specific platform file

Comment 3

[François Tigeot]

These first two attached files should be put into the pr/include/md/ directory.

Comment 4

[François Tigeot]

Attachment: Patch adding two DragonFly-specific files

Same files, in a git-style patch

Comment 5

[Landry Breuil (:gaston)]

Comment on attachment 764980 [details] [diff] [review]
Patch adding two DragonFly-specific files

trailing & wrong #endif /* nspr_freebsd_defs_h___ */ at the bottom of the diff :)

Deferring to wtc

Comment 6

[François Tigeot]

The comment is indeed wrong, the last line should be:
#endif /* nspr_dragonfly_defs_h___ */

Not sure if that's worth an updated patch file...

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 764980 [details] [diff] [review]
Patch adding two DragonFly-specific files

Review of attachment 764980 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, although I don't really know enough details to comment more specifically.

Comment 8

[Landry Breuil (:gaston)]

Francois, is this still accurate wrt the specificites of dfly those days ? If so i'll land it soonish (with the nit from comment #6...)

Comment 9

[François Tigeot]

The patch is still good even though it now contains some obsolete parts.

I'll open a separate bug report later to remove 32-bit x86 support if this code ever makes it to the nspr repository.

Comment 10

[Landry Breuil (:gaston)]

ted, shall i just land it as-is to nspr repo, or some approval is needed ? i never remember the rules for this repo..

Francois, what's the obsolete 32-bits chunk besides +#define _PR_SI_ARCHITECTURE "x86" ?

Comment 11

[François Tigeot]

The code protected with defined(__i386__) includes in _dragonfly.cfg

Comment 12

[(not currently active) Ted Mielczarek]

You need an NSPR peer to land NSPR patches for you. If this is ready to go then needinfo me and I'll land it.

Comment 13

[Landry Breuil (:gaston)]

francois, can you upload a fixed patch without the i386/32 bits parts so that ted can finally land this ?

Comment 14

[François Tigeot]

Attachment: New file: _dragonfly.cfg

Comment 15

[François Tigeot]

Attachment: New file: _dragonfly.h

Comment 16

[François Tigeot]

Attachment: Adapt uxwrap.c for DragonFly poll(2) support

Comment 17

[François Tigeot]

Attachment: New file: _dragonfly.h

Comment 18

[François Tigeot]

I have updated the patches and added missing poll(2) support in the process.

Comment 19

[(not currently active) Ted Mielczarek]

I have resigned as NSPR module owner. Sorry for the inconvenience.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.