B2G: Add missing request in mozJSComponentLoader::UnloadModules

RESOLVED FIXED in mozilla24

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

unspecified
mozilla24
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
During b2g desktop shutdown I get
Assertion failure: cx->runtime()->requestDepth || cx->runtime()->isHeapBusy(), at /Volumes/mac/code/src/js/src/jscntxt.cpp:1491

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
JS::AutoCheckRequestDepth::AutoCheckRequestDepth (this=0x7fff5fbfeb70, cx=0x1005343a0) at /Volumes/mac/code/src/js/src/jscntxt.cpp:1491
1491	    JS_ASSERT(cx->runtime()->requestDepth || cx->runtime()->isHeapBusy());
(gdb) bt
#0  JS::AutoCheckRequestDepth::AutoCheckRequestDepth (this=0x7fff5fbfeb70, cx=0x1005343a0) at /Volumes/mac/code/src/js/src/jscntxt.cpp:1491
#1  0x00000001056114ad in JS::AutoCheckRequestDepth::AutoCheckRequestDepth (this=0x7fff5fbfeb70, cx=0x1005343a0) at /Volumes/mac/code/src/js/src/jscntxt.cpp:1494
#2  0x00000001055ad893 in JS_SetAllNonReservedSlotsToUndefined (cx=0x1005343a0, objArg=0x10ed37100) at /Volumes/mac/code/src/js/src/jsapi.cpp:4585
#3  0x00000001032d3248 in mozJSComponentLoader::UnloadModules (this=0x10053ea40) at /Volumes/mac/code/src/js/xpconnect/loader/mozJSComponentLoader.cpp:1131
#4  0x00000001032da9aa in mozJSComponentLoader::Observe (this=0x10053ea40, subject=0x0, topic=0x105d12709 "xpcom-shutdown-loaders", data=0x0) at /Volumes/mac/code/src/js/xpconnect/loader/mozJSComponentLoader.cpp:1460
#5  0x00000001032daa1f in non-virtual thunk to mozJSComponentLoader::Observe(nsISupports*, char const*, unsigned short const*) () at /Volumes/mac/code/src/js/xpconnect/loader/mozJSComponentLoader.cpp:1465
#6  0x000000010433204a in mozilla::ShutdownXPCOM (servMgr=0x0) at /Volumes/mac/code/src/xpcom/build/nsXPComInit.cpp:670
#7  0x0000000104331a75 in NS_ShutdownXPCOM (servMgr=0x100596338) at /Volumes/mac/code/src/xpcom/build/nsXPComInit.cpp:540
#8  0x000000010154817b in ScopedXPCOMStartup::~ScopedXPCOMStartup (this=0x10050d3a8) at /Volumes/mac/code/src/toolkit/xre/nsAppRunner.cpp:1129
#9  0x0000000101548095 in ScopedXPCOMStartup::~ScopedXPCOMStartup (this=0x10050d3a8) at /Volumes/mac/code/src/toolkit/xre/nsAppRunner.cpp:1110
#10 0x00000001015511e1 in XREMain::XRE_main (this=0x7fff5fbfef78, argc=3, argv=0x7fff5fbffb60, aAppData=0x1000081d0)
(Assignee)

Comment 1

5 years ago
Created attachment 764996 [details] [diff] [review]
patch
Assignee: nobody → anygregor
(Assignee)

Comment 2

5 years ago
Faster than I can compile :)
(Assignee)

Comment 3

5 years ago
Should go into leo because it's minimal risk and it can cause gc hazards during shutdown otherwise.
blocking-b2g: --- → leo?
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
Oh never mind. That is fixed on b2g18.
blocking-b2g: leo? → ---

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/12ba48be5b78
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.