Invalidate Contacts cache when the system language is changed

NEW
Unassigned

Status

()

Core
DOM: Contacts
5 years ago
5 years ago

People

(Reporter: reuben, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We have to throw away our sorting cache when the system language changes, since the behavior of String.prototype.localeCompare also changes.

Updated

5 years ago
Component: DOM: Device Interfaces → DOM: Contacts

Comment 1

5 years ago
Created attachment 826424 [details] [diff] [review]
clearCache.diff
Attachment #826424 - Flags: review?(gwagner)
Comment on attachment 826424 [details] [diff] [review]
clearCache.diff

The wrong gregor wagner :)
Attachment #826424 - Flags: review?(gwagner) → review?(reuben.bmo)
(Reporter)

Comment 3

5 years ago
Comment on attachment 826424 [details] [diff] [review]
clearCache.diff

Review of attachment 826424 [details] [diff] [review]:
-----------------------------------------------------------------

Generally this looks fine, but if I remember correctly the reason I didn't do anything about this bug is that we always used en-US when sorting in the parent. This may not longer be the case, but I want to double check that we're not throwing away caches for nothing.
Attachment #826424 - Flags: review?(reuben.bmo) → feedback+
You need to log in before you can comment on or make changes to this bug.