Closed Bug 885074 Opened 6 years ago Closed 6 years ago
Clean up old stuff in makefiles
Basically, I went through <http://www.tjhsst.edu/~jcranmer/bxr-comm-central.html>, looked at every variable set but not referenced and deleted those that did nothing (as verified by a MXR search). That list is: BUILD_SMIME EXTRA_DSO_LIBS FORCE_USE_PIC GENERATE_CACHE GRE_MODULE REQUIRES SRCS_IN_OBJDIR I furthermore deleted the following files: * calendar/providers/gdata/build.mk - Apparently, we used to support building gdata as an application. That would have stopped working as of the first moz.build changes at the latest, and possibly well before them, so I opted just to delete this altogether rather than trying to get it to work * mail/extensions/Makefile.in - empty makefile * */extradependlibs.mk - As far as I can tell, these have been unnecessary for quite some time. * suite/app-config.mk - The first two variables should be set by configure, the latter is just retriggering on changes in app-config, so it's unnecessary * mail/app-config.mk - I could have deleted this as well, but the inclusion of calendar/lightning/app-config.mk appears to be ease of Lightning development, so I opted not to. Finally, I removed EXTRA_DSO_LDOPTS from every Makefile which doesn't produce a shared library, as measured by building with --enable-incomplete-external-linkage. Try run with this and a few other patches here: https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=77cbaaba1f0d
Comment on attachment 765038 [details] [diff] [review] Remove lots of things This didn't apply cleanly for me when I tried it.
This runs on top of the LIBRARY_NAME migration in my patch queue.
This applies on a clean tree.
Attachment #785799 - Flags: review?(mbanner) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in before you can comment on or make changes to this bug.