Closed Bug 885096 Opened 7 years ago Closed 6 years ago

hasMutex should not be called from a lazy getter

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file, 1 obsolete file)

Because lazy getters are only called once and the value for hasMutex can change.
Attached patch patch rev1 (obsolete) — Splinter Review
Also fixes a strict warning.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #8360154 - Flags: review?(netzen)
Comment on attachment 8360154 [details] [diff] [review]
patch rev1

meh... somehow I missed another lazy getter using it
Attachment #8360154 - Attachment is obsolete: true
Attachment #8360154 - Flags: review?(netzen)
Attached patch patch rev2Splinter Review
Attachment #8360190 - Flags: review?(netzen)
Attachment #8360190 - Flags: review?(netzen) → review+
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/70a04464772f
Flags: in-testsuite+
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/70a04464772f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.