Closed Bug 885103 Opened 6 years ago Closed 6 years ago

Do not display total compilation time messages with different shell flags when asm.js is successfully compiled, in a --enable-more-deterministic shell

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: gkw, Assigned: gkw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fuzzblocker])

Attachments

(1 file)

warning: successfully compiled asm.js code (total compilation time 0ms)

When asm.js successfully compiles, the total compilation time is displayed. This causes issues with compareJIT because running the testcase with different flags will almost always incur different times, so compareJIT gets confused and treats the testcase as interesting, even though the only thing that differed is the time.

We should move the total compilation time into a #ifndef JS_MORE_DETERMINISTIC block, i.e. not display the times when compiling a --enable-more-deterministic shell so as not to trip up compareJIT.
Taking. With help from Luke, a patch is on the way...
Assignee: general → gary
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
This patch, as suggested by Luke, forces the total compilation time to always be 0ms no matter the flags used.

Thus, such time stats are no longer accurate with --enable-more-deterministic shells, but these shells shouldn't really be used for benchmarking anyway (for this, use the regular shells, which is what we ship).
Attachment #765083 - Flags: review?(luke)
Attachment #765083 - Flags: review?(luke) → review+
mozilla-inbound is closed, setting checkin-needed keyword for whoever gets to this first (me or someone else).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/661b48de7a70
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
I'd prefer not showing a time to showing an incorrect time.
(In reply to Jesse Ruderman from comment #6)
> I'd prefer not showing a time to showing an incorrect time.

Luke, thoughts?
Flags: needinfo?(luke)
Whatever you guys want.
Flags: needinfo?(luke)
Summary: Do not display total compilation time when asm.js is successfully compiled, in a --enable-more-deterministic shell → Do not display total compilation time messages with different shell flags when asm.js is successfully compiled, in a --enable-more-deterministic shell
Depends on: 886481
Whiteboard: [fuzzblocker]
Blocks: 881882
You need to log in before you can comment on or make changes to this bug.