I assume this is related to the patch that landed that extracts the name from the app manifest. http://i.imgur.com/WZhYOfn.png Because their app names are blank, apps with the following ids cannot be reviewed: 439042 439050 439086 439098
Its bug 836147 that causes the missing names. And then I think Mat's patch to fix the emails going out with odd localization stopped us from being able to reject them too (because it couldn't handle the name being null).
I agree, it looks like this is caused by bug 836147. My recent patch was for developer name, not app name. As for the emails, the code simply switches to the default_locale, so it should pick up the original, untranslated name if the default_locale is unsupported (and it does in my testing)
(In reply to Mathieu Pillard [:mat] from comment #2) > As for the emails, the > code simply switches to the default_locale, so it should pick up the > original, untranslated name if the default_locale is unsupported (and it > does in my testing) Does is handle there being no name? I.e. the name in the DB is null.
I don't think any part of our code handles that gracefully, so probably not, no, but that shouldn't happen. Shouldn't bug 836147 take care of this (excluding existing apps) ?
It won't fix existing apps so we'll have to work around those with some manual emailing and admin tool disabling.
Marking dependent on bug 836147. Once that is done someone can do cleanup of the few in prod
these are the 5 remaining apps with no name: https://marketplace.firefox.com/reviewers/apps/review/none-20 https://marketplace.firefox.com/reviewers/apps/review/none-21 https://marketplace.firefox.com/reviewers/apps/review/none-23 https://marketplace.firefox.com/reviewers/apps/review/none-25 https://marketplace.firefox.com/reviewers/apps/review/forkortelser
Adding dependency on 2 more bugs causing nameless apps (either "true" nameless apps or apps a blank name in some locale)
I've manually dealt with all the apps bar /none-25, which is going to hit bug 891376 if they resubmit now. Once that's fixed I'll delete and email that developer too.
i'll fix the last one and close on Friday after the push.
I manually dealt with all the apps with empty names and the underlying issue was fixed in other bugs so closing.