Apps without names cannot be rejected in prod

RESOLVED FIXED in 2013-08-06

Status

Marketplace
Reviewer Tools
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: cvan, Assigned: eviljeff)

Tracking

2013-08-06
Points:
---
Dependency tree / graph

Details

(URL)

(Reporter)

Description

5 years ago
I assume this is related to the patch that landed that extracts the name from the app manifest.

http://i.imgur.com/WZhYOfn.png

Because their app names are blank, apps with the following ids cannot be reviewed:

439042
439050
439086
439098
(Assignee)

Comment 1

5 years ago
Its bug 836147 that causes the missing names.  And then I think Mat's patch to fix the emails going out with odd localization stopped us from being able to reject them too (because it couldn't handle the name being null).
Summary: Apps without names cannot be approved in prod → Apps without names cannot be rejected in prod
I agree, it looks like this is caused by bug 836147.

My recent patch was for developer name, not app name. As for the emails, the code simply switches to the default_locale, so it should pick up the original, untranslated name if the default_locale is unsupported (and it does in my testing)
(Assignee)

Comment 3

5 years ago
(In reply to Mathieu Pillard [:mat] from comment #2)
> As for the emails, the
> code simply switches to the default_locale, so it should pick up the
> original, untranslated name if the default_locale is unsupported (and it
> does in my testing)

Does is handle there being no name?  I.e. the name in the DB is null.
I don't think any part of our code handles that gracefully, so probably not, no, but that shouldn't happen. Shouldn't bug 836147 take care of this (excluding existing apps) ?
(Assignee)

Comment 5

5 years ago
It won't fix existing apps so we'll have to work around those with some manual emailing and admin tool disabling.
(Assignee)

Comment 6

5 years ago
whoops, misread comment #4.  Yes, bug 836147 will/should stop this from happening any more.
Marking dependent on bug 836147.  Once that is done someone can do cleanup of the few in prod
Depends on: 836147
Priority: -- → P2
(Assignee)

Comment 8

5 years ago
these are the 5 remaining apps with no name:
https://marketplace.firefox.com/reviewers/apps/review/none-20
https://marketplace.firefox.com/reviewers/apps/review/none-21
https://marketplace.firefox.com/reviewers/apps/review/none-23
https://marketplace.firefox.com/reviewers/apps/review/none-25
https://marketplace.firefox.com/reviewers/apps/review/forkortelser
Adding dependency on 2 more bugs causing nameless apps (either "true" nameless apps or apps a blank name in some locale)
Assignee: nobody → mpillard
Depends on: 891370, 891376
(Assignee)

Comment 10

5 years ago
I've manually dealt with all the apps bar /none-25, which is going to hit bug 891376 if they resubmit now.  Once that's fixed I'll delete and email that developer too.
(Assignee)

Comment 11

4 years ago
i'll fix the last one and close on Friday after the push.
Assignee: mpillard → awilliamson
(Assignee)

Comment 12

4 years ago
I manually dealt with all the apps with empty names and the underlying issue was fixed in other bugs so closing.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-08-08
You need to log in before you can comment on or make changes to this bug.