885150 - Paid apps are showing up in search results

Status: RESOLVED FIXED

(Marketplace Graveyard :: Search, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Make sure the flag "allow-paid-app-search" is OFF
2. Approve a paid app
3. Search for the app by its name in one of the supported region

expected behavior:
App doesn't show up in search results

observed behavior:
App shows up

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Here's where we do the filtering: https://github.com/mozilla/zamboni/blob/master/mkt/webapps/models.py#L653

So I'm not sure what the problem is, but I can totally reproduce.

Comment 2

[Rob Hudson [:robhudson]]

Can you provide an example on -dev that I can look at?

Note that disabling the flag will take 5 minutes for caches to clear.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

1) Upload an app in Seville.
2) Approve the app.
3) Go to search results and search for said app.
4) Notice that app shows up in search results.

We experienced this in production, but I've since disabled the paid app that I submitted.

Comment 4

[Rob Hudson [:robhudson]]

I see what's happening. I'll try to get a fix up soon.

Comment 5

[Rob Hudson [:robhudson]]

Let's try this:
https://github.com/mozilla/zamboni/commit/95643c7