Closed
Bug 885182
Opened 11 years ago
Closed 11 years ago
IonScript data fields aligned to 4 bytes even on x64
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: sunfish, Unassigned)
Details
Attachments
(1 file)
|
982 bytes,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
In Ion.cpp, DataAlignment is unconditionally set to 4. This causes several data fields, including fields containing pointers, to be aligned on 4-byte boundaries, causing accesses to them to be misaligned accesses.
|
Reporter | |
Comment 1•11 years ago
|
||
sizeof(void *) ought to be a reasonable default setting. That way, pointer data will be aligned on all popular architectures.
Attachment #765176 -
Flags: review?(mrosenberg)
|
||
Updated•11 years ago
|
Attachment #765176 -
Flags: review?(mrosenberg) → review+
|
|
Reporter | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc2e2aff6206
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc2e2aff6206
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Comment 4•11 years ago
|
||
mjrosenb: I think we also we to align on 8 bytes on ARM, such as we can have fast loads of double extracted from the constant stored for bailouts and others?
Flags: needinfo?(mrosenberg)
You need to log in
before you can comment on or make changes to this bug.
Description
•