Don't use getPageTitle in PlacesTagURITransaction

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
6 years ago
5 years ago

People

(Reporter: mano, Unassigned)

Tracking

unspecified
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog -

Firefox Tracking Flags

(Not tracked)

Details

______________
So... what's the story for async transaction managers? I'm pretty sure nsITransactionManager assumes synchronous implementations in many ways. Unfortunately this issue applies to all places transactions. This bug won't cover that.
______________

PlacesTagURITransaction is using getPageTitle. It shouldn't. If the issue mentioned above isn't major, it could be swiitched to getPlacesInfo right away.  If it is, then its caller would have to provide it with the title. Alternatively, we could avoid storing titles for these hacky-bookmarks and always show the title from history.
I'm not sure how we will handle the transactions, but likely we won't be able to just use nsITransactionManager directly as we do today, but we'll have to wrap everything into a new transactions module with its own serialized API.
Whiteboard: p=0
Team determined that this bug will be 'Wonfix' at the point estimation meeting.
No longer blocks: fxdesktopbacklog
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: firefox-backlog-
Resolution: --- → WONTFIX
Whiteboard: p=0
the reason is that with async transactions we will not use this api, so there's no reason to update the old transactions.
You need to log in before you can comment on or make changes to this bug.