Closed
Bug 885251
Opened 11 years ago
Closed 10 years ago
Don't use getPageTitle in PlacesTagURITransaction
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: asaf, Unassigned)
References
Details
______________ So... what's the story for async transaction managers? I'm pretty sure nsITransactionManager assumes synchronous implementations in many ways. Unfortunately this issue applies to all places transactions. This bug won't cover that. ______________ PlacesTagURITransaction is using getPageTitle. It shouldn't. If the issue mentioned above isn't major, it could be swiitched to getPlacesInfo right away. If it is, then its caller would have to provide it with the title. Alternatively, we could avoid storing titles for these hacky-bookmarks and always show the title from history.
Comment 1•11 years ago
|
||
I'm not sure how we will handle the transactions, but likely we won't be able to just use nsITransactionManager directly as we do today, but we'll have to wrap everything into a new transactions module with its own serialized API.
Updated•10 years ago
|
Blocks: fxdesktopbacklog
Whiteboard: p=0
Comment 2•10 years ago
|
||
Team determined that this bug will be 'Wonfix' at the point estimation meeting.
No longer blocks: fxdesktopbacklog
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: firefox-backlog-
Resolution: --- → WONTFIX
Whiteboard: p=0
Comment 3•10 years ago
|
||
the reason is that with async transactions we will not use this api, so there's no reason to update the old transactions.
You need to log in
before you can comment on or make changes to this bug.
Description
•