885329 - Stop generating useless icon sizes

Status: VERIFIED FIXED

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Mathieu Pillard [:mat]]

Marketplace re-uses amo.ADDON_ICON_SIZES when generating icons for an app. But we only expose/need (16, 48, 64, 128). So we end up generating a 256 or 512 version, which isn't used and just wastes disk space/cpu time. 

To make things worse, in many (all?) cases those 256 or 512 versions are actually 128x128, which is the biggest size we ask for in the manifest.

Comment 1

[Matt Basta [:basta]]

We currently only use (to the best of my knowledge) 32 (in rocketfuel), 64, and 128. There are very few apps that have icons larger than 128.

Comment 2

[Soledad Penades [:sole] [:spenades]]

https://developer.mozilla.org/en-US/Apps/Build/Manifest#icons says that 128 and 256 are used in Windows/Android.

Comment 3

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/2223

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/50c87c539586075265e89242118bdbd34847f656

QA:
- Submit an app with a 128x128 icon
- Verify that the icon is correctly shown in the devhub, reviewer tools and public pages (once approved)

Comment 5

[Madalin Cotetiu]

Verified as fixed in https://marketplace-dev.allizom.org on FF33 (Win 7).

Postfix screencasts
 devhub & reviewer tools: http://screencast.com/t/zuTVGzOqZkC
 public pages: http://screencast.com/t/oktTNZmP8to

Closing.