Stop generating useless icon sizes

VERIFIED FIXED in 2014-06-24

Status

Marketplace
Code Quality
P4
normal
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: mat, Assigned: mat)

Tracking

({perf})

2014-06-24
x86_64
Linux
Points:
---

Details

(Whiteboard: [repoman])

(Assignee)

Description

5 years ago
Marketplace re-uses amo.ADDON_ICON_SIZES when generating icons for an app. But we only expose/need (16, 48, 64, 128). So we end up generating a 256 or 512 version, which isn't used and just wastes disk space/cpu time. 

To make things worse, in many (all?) cases those 256 or 512 versions are actually 128x128, which is the biggest size we ask for in the manifest.

Updated

5 years ago
Priority: -- → P4
Whiteboard: [perf]

Comment 1

4 years ago
We currently only use (to the best of my knowledge) 32 (in rocketfuel), 64, and 128. There are very few apps that have icons larger than 128.
Keywords: perf
Whiteboard: [perf]

Updated

4 years ago
Blocks: 983866
No longer blocks: 983866
Blocks: 992365
(Assignee)

Updated

4 years ago
No longer blocks: 992365
https://developer.mozilla.org/en-US/Apps/Build/Manifest#icons says that 128 and 256 are used in Windows/Android.
(Assignee)

Updated

4 years ago
Depends on: 924629
(Assignee)

Updated

4 years ago
Assignee: nobody → mpillard
Whiteboard: [repoman]
Target Milestone: --- → 2014-06-10
(Assignee)

Comment 3

4 years ago
https://github.com/mozilla/zamboni/pull/2223
Status: NEW → ASSIGNED
Target Milestone: 2014-06-10 → 2014-06-24
(Assignee)

Comment 4

4 years ago
Fixed in https://github.com/mozilla/zamboni/commit/50c87c539586075265e89242118bdbd34847f656

QA:
- Submit an app with a 128x128 icon
- Verify that the icon is correctly shown in the devhub, reviewer tools and public pages (once approved)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 5

4 years ago
Verified as fixed in https://marketplace-dev.allizom.org on FF33 (Win 7).

Postfix screencasts
 devhub & reviewer tools: http://screencast.com/t/zuTVGzOqZkC
 public pages: http://screencast.com/t/oktTNZmP8to

Closing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.