885367 - editing a project and removing the title element causes a crash

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Scott [:thecount] Downe]

/home/scott/thimble.webmaker.org/node_modules/sqlite3/lib/trace.js:28
                    throw err;
                          ^
TypeError: Cannot read property 'title' of undefined

STRS:

1. load up an empty project.
2. save it.
3. save it again.

Expected: a published project.
Actual: A crash.

The first save is fine, as it's not an edit. Second save is the one that breaks because our url is now /:id/edit

Comment 1

[Scott [:thecount] Downe]

I missed a key step in my STRS. Remove the title in step 1.

Comment 2

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/149

Comment 3

[Pomax]

Comment on attachment 765421 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/149

hmm, concern about leaving the page title empty when there is not title element, since we publish based on the title.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 765421 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/149

If there is no title element we do what we used to do if there was no title in the element, and that is use the project's id as the title.

Comment 5

[Pomax]

Comment on attachment 765421 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/149

if we're not pushing to /, then this is r+

Comment 6

[David Humphrey (:humph)]

Can we get this landed please?

Comment 7

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/c32388573fbe2cd9c66ec73b168fe4be80f4ebb0

Was just landing another ticket, and ensuring they worked together before landing this.