885377 - Fix or remove metrics postings

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Rob Hudson [:robhudson]]

The logs have this in it quite a bit. I don't know what this is from but we should probably fix or remove if it's not needed.

[<anon>][None] z.metrics:ERROR Posting to metrics failed uuid: fe511c44-3ef9-462f-9d81-161ba6208e5a :/data/www/addons.mozilla.org/zamboni/lib/metrics/__init__.py:84#012Traceback (most recent call last):#012  File "/data/www/addons.mozilla.org/zamboni/lib/metrics/__init__.py", line 76, in metrics#012    response = urllib2.urlopen(request, timeout=timeout)#012  File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen#012    return _opener.open(url, data, timeout)#012  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/object_wrapper.py", line 216, in __call__#012    self._nr_instance, args, kwargs)#012  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/external_trace.py", line 60, in dynamic_wrapper#012    return wrapped(*args, **kwargs)#012  File "/usr/lib64/python2.6/urllib2.py", line 391, in open#012    response = self._open(req, data)#012  File "/usr/lib64/python2.6/urllib2.py", line 409, in _open#012    '_open', req)#012  File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain#012    result = func(*args)#012  File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open#012    return self.do_open(httplib.HTTPSConnection, req)#012  File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open#012    raise URLError(err)#012URLError: <urlopen error [Errno 8] _ssl.c:490: EOF occurred in violation of protocol>

Comment 1

[Rob Hudson [:robhudson]]

A bit nicer formatting for the traceback:

[<anon>][None] z.metrics:ERROR Posting to metrics failed uuid: fe511c44-3ef9-462f-9d81-161ba6208e5a :/data/www/addons.mozilla.org/zamboni/lib/metrics/__init__.py:84
Traceback (most recent call last):
  File "/data/www/addons.mozilla.org/zamboni/lib/metrics/__init__.py", line 76, in metrics
    response = urllib2.urlopen(request, timeout=timeout)
  File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/newrelic-1.11.0.55/newrelic/api/external_trace.py", line 60, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "/usr/lib64/python2.6/urllib2.py", line 391, in open
    response = self._open(req, data)
  File "/usr/lib64/python2.6/urllib2.py", line 409, in _open
    '_open', req)
  File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
    result = func(*args)
  File "/usr/lib64/python2.6/urllib2.py", line 1198, in https_open
    return self.do_open(httplib.HTTPSConnection, req)
  File "/usr/lib64/python2.6/urllib2.py", line 1165, in do_open
    raise URLError(err)
URLError: <urlopen error [Errno 8] _ssl.c:490: EOF occurred in violation of protocol>

Comment 2

[Andy McKay]

We can remove this code, and let metrics know.

Comment 3

[Andy McKay]

Xavier, we've gone a slightly different direction on metrics, so we are going to remove this ping. Letting you know so you can remove the end point at your end.

Thanks for this setup.

Comment 4

[Andy McKay]

The endpoint you set up was detailed here in bug 753195.

Comment 5

[Andy McKay]

r? @ametaireau https://github.com/mozilla/zamboni/pull/833

Comment 6

[Andy McKay]

https://github.com/mozilla/zamboni/commit/ae79ac