885384 - Improve Make Editor Pagination

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Chris DeCairos (:cade)]

It limits the search results to 1000, but there could be far more hits.

I'm going to explore how I can do this and post my findings.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/129/files

I've written a custom Paging tool I've lovingly dubbed the "MakePager"

I've grabbed all the script/css dependencies that were being loaded from remote sources and added the minified versions to our repo.

I included font-awesome to use for the MakePager's control elements.

Basically, what this new tool does is remove the 1000 make limit we had by making requests to the MakeAPI 100 Makes at a time, page by page, while leveraging the total hits variable now available from the MakeAPI.

I tried to keep it as modular as I could (but didn't separate it into a different file - which I could if you made me)

dale: this code needs some serious reviewing, so buckle up! I can also help you get a whole bunch of fake makes to test with if you need them.

Comment 3

[Dale Karp (:daleee)]

Comment on attachment 785003 [details]
https://github.com/mozilla/MakeAPI/pull/129/files

Tested locally, tried to break it but it would not break!
Looked through code, looks good to me!

Comment 4

[Chris DeCairos (:cade)]

woo! Gonna get this onto staging for some more testing in that case!

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/7fc256586350369dbcfb54d4f9a04af7306d4505
Bug 885384 - Write custom paging tool for make editor, use local versions of script dependencies, add font-awesome for MakePager UI

Comment 6

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/130

This fixes some minor issues with the first patch that I caught on staging.

1. Loading spinny while it fetches pages - very useful
2. The trimItems function was moved out of scope of one its callers
3. Removed majority of jQuery Usage in favour of pure JS for DOM manipulation and event setup

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/0a77ebec892be50cb3eee4c66e01e879c3246726
Bug 885384 - MakePager and Admin.js updates

Comment 8

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/131

One more upgrade: Adds setting of the page size.

also fixes the click callback for adding an API key.

Comment 9

[Dale Karp (:daleee)]

Comment on attachment 785214 [details] [review]
https://github.com/mozilla/MakeAPI/pull/131

Code looks fine, works locally.

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/6a1af0064fe2b7783505b46ad88d332844467245
Bug 885384 - total results toggle + other fixes

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/01dd93a7718ee8ee6c6167b547e94611a4ea5d14
Bug 885384 - Handle page numbers out of range when changing the max results per page value

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/8fa0e12667f7a91e0f8b9555a1ab963ce663832c
Bug 885384 - Fix search button