Use default clipping for -[ChildView drawRect:]

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla25
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 765436 [details] [diff] [review]
patch

In bug 676241 I added more drawing to the end of -[ChildView drawRect:] for non-accelerated drawing:

  if ([self isCoveringTitlebar]) {
    [self drawTitlebarHighlight];
    [self maskTopCornersInContext:aContext];
  }

This drawing wasn't clipped to the dirty region until I added a CGContextClipToRects call. I now know why: There's a wantsDefaultClipping method which we returned NO from. We can just get rid of that.
It was added in 2004: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/widget/src/cocoa&command=DIFF_FRAMESET&file=nsChildView.mm&rev2=1.84&rev1=1.83
Attachment #765436 - Flags: review?(matt.woodrow)
Attachment #765436 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/4ba6bcb509b0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.