Create new tests for currently untested modules

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: Gabriela Thumé, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130512194440

Steps to reproduce:

Based on script results available at https://gist.github.com/GabiThume/5808574 and Adrian Gaudebert's feedback at mailing list, we need to create new tests for the currently untested modules:

In lib:
['socorro/socorro/lib/productVersionCache.py', 'socorro/socorro/lib/uuid.py', 'socorro/socorro/lib/threadlib.py', 'socorro/socorro/lib/stats.py']
 
In monitor:
['socorro/socorro/monitor/monitor_app.py', 'socorro/socorro/monitor/crashstore_new_crash_source.py']
 
In cron:
['socorro/socorro/cron/jobs/buggy.py']
 
In collector:
['socorro/socorro/collector/submitter.py', 'socorro/socorro/collector/submitter_app.py']
As requested, advice on what to start with:

1. Eliminate what's deprecated.
2. Eliminate what's already covered by dint of testing other things.
3. Then start with what's left.

Nose has a --with-coverage flag that can show you what's uncovered.
everything in this list is slated for deprecation with the following exceptions:

.../socorro/collector/submitter_app.py
.../socorro/cron/jobs/buggy.py
.../socorro/lib/uuid.py

no effort to write tests should be taken on files to be deprecated.

the file .../socorro/lib/uuid.py is a special case in that it appears to have been copied from an external source and is not ours - our license header should not be on that file.
(Reporter)

Comment 3

5 years ago
So, considering these comments, should just /socorro/collector/submitter_app.py and /socorro/cron/jobs/buggy.py be tested?
(Reporter)

Comment 4

5 years ago
I am sorry for copying this here, but it is really useful for finding the deprecated files!

An email from Adrian Gaudebert:

" To the extent of my knowledge:

socorro/socorro/lib/httpclient.py -- no need to test it, it's dead simple and should be made obsolete in the near future
socorro/socorro/app/example_app.py -- just an example, no test needed
socorro/socorro/external/fs/crash_data.py -- I think we can use the exact same test as for socorro/socorro/external/filesystem/crash_data.py (after all, those two files should behave exactly the same)

There is no need to test any of the files listed for socorro/socorro/middleware/, those are depreciated and will disappear when we switch to the new configman-based middleware. "
I think the comments in this bug suggest this is all set now. If that's not the case, please reopen.
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.