885452 - Remove retrieveToolbarIconsizesFromTheme now that we only support one icon size

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Matthew N. [:MattN]]

retrieveToolbarIconsizesFromTheme shows up fairly high in JS profiles of browser startup. I suspect it can be simplified to avoid calls to getComputedStyle now that we only support a single toolbar icon size (bug 863299). Since we don't provide UI to switch the icon size, I think 3rd-party themes can make icons larger with CSS if they desire. If an extension wants to put the functionality back, they can implement this function and call it upon during browser initialization.

I'm going to do a try push to see its effect on tspaint_places_generated_*.

Comment 1

[Matthew N. [:MattN]]

Try push commenting out retrieveToolbarIconsizesFromTheme: https://tbpl.mozilla.org/?tree=Try&rev=13a5fa73decc

Comment 2

[Matthew N. [:MattN]]

It seems like this has negligible effect on tspaint_places_generated_* unfortunately. I guess it's not too much of surprise given that the running time was 0.1% in the profiler. It's still unnecessary work which we should remove if possible.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Marked addon-compat, because it's possible that some add-ons call this to deal with iconsize glitches.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/f3d225d45859

Comment 6

[Matthew N. [:MattN]]

Removing extra blocking bug since bug 863299 was already blocking australis-cust.

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/f3d225d45859