885536 - Intermittent browser_tabs_01.js | Left over tab after test: 'about:blank'

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Tests, defect)

Description

[Jim Mathies [:jimm]]

This never failed on try, but it did on on inbound push. Also it looks like our tab cleanup logic is blowing away the root tab when this happens. I'm guessing the last tab doesn't get shut down soon enough and get picked up, then closes, and our tab cleanup code comes along and blows away the root tab.

I'll see what I can do about this.

https://tbpl.mozilla.org/php/getParsedLog.php?id=24396983&tree=Mozilla-Inbound&full=1#error0

EST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'

..

WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

Make sure all tabs are have been cleaned up before exiting this test.

Comment 2

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=24409403&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test mochitest-metro-chrome on 2013-06-20 18:30:08
revision: 66bbf82b9ec2
slave: t-w864-ix-004

18:35:08  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'
18:35:08  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494

Comment 3

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=24429506&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test mochitest-metro-chrome on 2013-06-21 09:41:15
revision: 29322de8937d
slave: t-w864-ix-118

09:47:15  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'
09:47:15  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 765620 [details] [diff] [review]
fix

Review of attachment 765620 [details] [diff] [review]:
-----------------------------------------------------------------

Its a shame the open/close tabs behavior isn't more determinate; Can "a little time" be replaced with next tick? Or is it really an unknown. r=me with the comment

::: browser/metro/base/tests/mochiperf/browser_tabs_01.js
@@ +34,5 @@
>        openDataSet.push(time);
>      }
> +
> +    // Give the browser a little time to clean up its tabs.
> +    yield waitForCondition(() => Browser.tabs.length == 2);

Can you comment where the magic number 2 comes from?

Comment 5

[Jim Mathies [:jimm]]

(In reply to Sam Foster [:sfoster] from comment #4)
> Comment on attachment 765620 [details] [diff] [review]
> fix
> 
> Review of attachment 765620 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Its a shame the open/close tabs behavior isn't more determinate; Can "a
> little time" be replaced with next tick? Or is it really an unknown. r=me
> with the comment

Actually closeTab is async unless you ask for it to be sync. I'll switch to doing that since this test measures open tab performance. Which might make the tab number check obsolete.

Comment 6

[Jim Mathies [:jimm]]

Attachment: export

Comment 7

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?tree=Try&showall=0&rev=f567974e65ab

Comment 8

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=24448987&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test mochitest-metro-chrome on 2013-06-21 18:39:47
revision: 97ff13b79e53
slave: t-w864-ix-054

18:46:37  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'
18:46:37  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494

Comment 9

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=24451369&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound opt test mochitest-metro-chrome on 2013-06-21 19:31:00
revision: 1b81a9c88872
slave: t-w864-ix-081

19:35:49  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'
19:35:49  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494

Comment 10

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0715ae1e4b4

Comment 11

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=24467751&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound pgo test mochitest-metro-chrome on 2013-06-22 06:25:02
revision: 98495bda6468
slave: t-w864-ix-010

06:31:01  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'
06:31:01  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494
06:31:34  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_context_menu_tests.js | runTests: Task failed - Error: dl-done event timeout at @chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/head.js:412

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e0715ae1e4b4