Closed Bug 885536 Opened 11 years ago Closed 11 years ago

Intermittent browser_tabs_01.js | Left over tab after test: 'about:blank'

Categories

(Firefox for Metro Graveyard :: Tests, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

This never failed on try, but it did on on inbound push. Also it looks like our tab cleanup logic is blowing away the root tab when this happens. I'm guessing the last tab doesn't get shut down soon enough and get picked up, then closes, and our tab cleanup code comes along and blows away the root tab.

I'll see what I can do about this.

https://tbpl.mozilla.org/php/getParsedLog.php?id=24396983&tree=Mozilla-Inbound&full=1#error0

EST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochiperf/browser_tabs_01.js | Left over tab after test: 'about:blank'

..

WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/metro/browser/metro/base/tests/mochitest/browser_bookmarks.js | uncaught exception - TypeError: aTab.chromeTab is null at chrome://browser/content/browser.js:494
Attached patch fixSplinter Review
Make sure all tabs are have been cleaned up before exiting this test.
Attachment #765620 - Flags: review?(sfoster)
Comment on attachment 765620 [details] [diff] [review]
fix

Review of attachment 765620 [details] [diff] [review]:
-----------------------------------------------------------------

Its a shame the open/close tabs behavior isn't more determinate; Can "a little time" be replaced with next tick? Or is it really an unknown. r=me with the comment

::: browser/metro/base/tests/mochiperf/browser_tabs_01.js
@@ +34,5 @@
>        openDataSet.push(time);
>      }
> +
> +    // Give the browser a little time to clean up its tabs.
> +    yield waitForCondition(() => Browser.tabs.length == 2);

Can you comment where the magic number 2 comes from?
Attachment #765620 - Flags: review?(sfoster) → review+
(In reply to Sam Foster [:sfoster] from comment #4)
> Comment on attachment 765620 [details] [diff] [review]
> fix
> 
> Review of attachment 765620 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Its a shame the open/close tabs behavior isn't more determinate; Can "a
> little time" be replaced with next tick? Or is it really an unknown. r=me
> with the comment

Actually closeTab is async unless you ask for it to be sync. I'll switch to doing that since this test measures open tab performance. Which might make the tab number check obsolete.
Attached patch exportSplinter Review
https://hg.mozilla.org/mozilla-central/rev/e0715ae1e4b4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: