885546 - VCF importer saves type="UTF-8" in contact fields

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Reuben Morais [:reuben]]

+++ This bug was initially created as a clone of Bug #878820 +++

type is meant to be something like "home" or "work". The importer should not be saving that unless the vCard data actually specifies the type.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Reuben,

Is it possible to get the VCF file(s) you are using to reproduce this bug?

Comment 2

[Reuben Morais [:reuben]]

BEGIN:VCARD

VERSION:3.0

N;CHARSET=UTF-8:Bar;Foo;;;

FN;CHARSET=UTF-8:Foo Bar

BDAY;CHARSET=UTF-8:1975-05-20

TEL;CHARSET=UTF-8;TYPE=CELL:[phone]

EMAIL;CHARSET=UTF-8;TYPE=HOME:[e-mail]

ORG;CHARSET=UTF-8:;

END:VCARD

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This fix is quite important. Fixes other issues discovered while investigating the utf8 bug.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Hei Sergi, should it be included in v1.1?

Basically I'm asking if it should be a leo+ :)

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: New Github PR

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 768363 [details] [diff] [review]
New Github PR

Thanks Sergi

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged with SHA 1c290693db3fdeb1aa4ae98557ac983a8a32524f

Comment 9

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This fix is crucial to be in leo since importing VCard functionality doesn't work at all without this fix. Besides the UTF-8 issue it solves a bad reference to `mozContact` that leaves the importer in a frozen state.

IMPORTANT: This fix should be uplifted AFTER https://bugzilla.mozilla.org/show_bug.cgi?id=878820 is uplifted.

Comment 10

[Tony Chung [:tchung]]

(In reply to Sergi Mansilla from comment #9)
> This fix is crucial to be in leo since importing VCard functionality doesn't
> work at all without this fix. Besides the UTF-8 issue it solves a bad
> reference to `mozContact` that leaves the importer in a frozen state.
> 
> IMPORTANT: This fix should be uplifted AFTER
> https://bugzilla.mozilla.org/show_bug.cgi?id=878820 is uplifted.

I just asked if bug 878820 affects 1.1 branch.  if yes, triage will be willing to take the patch uplift for that bug and here too.

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged in v1-train: 368489e25f9406d6339e4414d6ce52b0caac0e5d

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 7f91a5b614c0885fd9ea7e4c1c6c8789f67428d2