Closed Bug 885598 Opened 9 years ago Closed 9 years ago

Mark some /embedding subdirs as FAIL_ON_WARNINGS

Categories

(Core Graveyard :: Embedding: APIs, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

With bug 885014 and bug 885596 fixed, we can mark a bunch of directories in /embedding as FAIL_ON_WARNINGS.

I verified that these directories all contain .cpp files which get compiled on at least one platform (which means the FAIL_ON_WARNINGS annotation actually has an effect.)
Attached patch fixSplinter Review
Attachment #765707 - Flags: review?(bzbarsky)
Try run:
 https://tbpl.mozilla.org/?tree=Try&rev=a9f197001b70

(In that push, the cset w/ message "imported patch embedding-webbrowser-failOnWarnings.patch" is the patch that's attached here; the patch right below that, for "mix-uint32_t-bool.patch", is the patch that's awaiting review over on bug 885596.)
Comment on attachment 765707 [details] [diff] [review]
fix

Woot -- bug 885596 landed, so this should be landable now, once it's got r+.

Updating review request to bsmedberg, as bz is on paternity leave.
Attachment #765707 - Flags: review?(bzbarsky) → review?(benjamin)
Attachment #765707 - Flags: review?(benjamin) → review+
Try push to be sure this is still valid:
 https://tbpl.mozilla.org/?tree=Try&rev=591832e19b82
Try looks good. Pushed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/c360f9876cd9
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/c360f9876cd9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.