Closed Bug 885602 Opened 9 years ago Closed 9 years ago

Fix build of AudioManager.cpp on gonk-JB

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix AudioManager.cpp (obsolete) — Splinter Review
Doing logical AND on nsresults is not permitted.
Attachment #765713 - Flags: review?(mchen)
Comment on attachment 765713 [details] [diff] [review]
Fix AudioManager.cpp

Review of attachment 765713 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioManager.cpp
@@ +284,4 @@
>  
>    nsCOMPtr<nsIObserverService> obs = services::GetObserverService();
>    NS_ENSURE_TRUE_VOID(obs);
> +  nsresult rv = obs->AddObserver(this, BLUETOOTH_SCO_STATUS_CHANGED_ID, false);

If rv is used to check in NS_FAILED(), maybe we can put entire function into NS_FAILED directly.
Same in obs->RemoveObserver().
Attachment #765713 - Flags: review?(mchen) → review+
Thanks for fixing this compile error.
Attachment #765713 - Attachment is obsolete: true
Thanks, mwu. :)
https://hg.mozilla.org/mozilla-central/rev/4ec6133f6ed4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.