testing/gtest/gtest is too old for clang++ -stdlib=libc++: 'tr1/tuple' file not found

RESOLVED FIXED in Firefox 24

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

Trunk
mozilla25
All
FreeBSD
Points:
---

Firefox Tracking Flags

(firefox24 fixed, firefox25 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In file included from testing/gtest/gmock/src/gmock-all.cc:40:
  In file included from testing/gtest/gmock/include/gmock/gmock.h:58:
  In file included from testing/gtest/gmock/include/gmock/gmock-actions.h:46:
  In file included from testing/gtest/gmock/include/gmock/internal/gmock-internal-utils.h:45:
  In file included from testing/gtest/gmock/include/gmock/internal/gmock-generated-internal-utils.h:42:
  In file included from testing/gtest/gmock/include/gmock/internal/gmock-port.h:45:
  In file included from testing/gtest/gtest/include/gtest/internal/gtest-linked_ptr.h:74:
  testing/gtest/gtest/include/gtest/internal/gtest-port.h:495:13: fatal error:
	'tr1/tuple' file not found
  #   include <tr1/tuple>
	      ^
  1 error generated.
  gmake[1]: *** [gmock-all.o] Error 1
Wild guess, try backporting bug 807492 part 3 to that copy of gtest ? See comment 70.
Err bug 807492 comment 69 i meant
(Assignee)

Comment 3

5 years ago
Created attachment 772896 [details] [diff] [review]
add c++11 mode from upstream

Basic support for c++11 (thus, libc++) was added in r621. And at least
r629 is required for OS X.
Attachment #772896 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #772896 - Flags: review?(bgirard) → review+
(Assignee)

Comment 4

5 years ago
Can someone push to Try?
https://tbpl.mozilla.org/?tree=Try&rev=36156602af04
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/e02367798aef
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e02367798aef
Assignee: nobody → jbeich
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(Assignee)

Comment 8

5 years ago
Comment on attachment 772896 [details] [diff] [review]
add c++11 mode from upstream

[Approval Request Comment]
Chasing bug 844288 to avoid regressing --enable-tests in some
configurations and platforms where libc++ is default.
Attachment #772896 - Flags: approval-mozilla-aurora?
Comment on attachment 772896 [details] [diff] [review]
add c++11 mode from upstream

PLease keep on eye on tests while landing on aurora
Attachment #772896 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/5d8474fe858d
status-firefox24: --- → fixed
status-firefox25: --- → fixed
Assuming this does not need QA.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.