Wi-Fi is enabling automatically after every reboot / airplane mode on-off even after disabling it.

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: vasanth, Assigned: vasanth)

Tracking

unspecified
ARM
All

Firefox Tracking Flags

(blocking-b2g:-, b2g18 affected)

Details

(Whiteboard: [mozilla-triage])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 765791 [details]
wifi.suspended is not inverse of wifi.enabled

1. In system app airplane_mode.js, during boot up/airplane mode off, 
wifi.suspended is used to restore wifi.enabled value

2. But in settings app wifi.js, it's assumed that wifi.suspended is !wifi.enabled


So in settings app, when wifi is turned off, wifi.suspended becomes true.
After reboot, wifi.suspended is used to restore wifi.enabled.
Since wifi.suspended is true, wifi is enabled again.

Attached patch fixes that issue.

Thanks,
Vasanth
Can you please attach the .patch file directly to the bug?
blocking-b2g: --- → leo?
status-b2g18: --- → affected
(Assignee)

Updated

5 years ago
Attachment #765791 - Attachment is obsolete: true
(Assignee)

Comment 2

5 years ago
Created attachment 765794 [details] [diff] [review]
wifi.suspended is not inverse of wifi.enabled
vasanth,

After the patch is uploaded, you need to request review to module owner, in this case, it should be :kaze or evelyn huang.
(Assignee)

Updated

5 years ago
Attachment #765794 - Flags: review?(kaze)

Comment 4

5 years ago
We don't feel strongly either way about this bug, so we'll leave it to partners to decide. Looping in UX to figure out expected behavior here.
Flags: needinfo?(firefoxos-ux-bugzilla)
Whiteboard: [mozilla-triage]
Comment on attachment 765794 [details] [diff] [review]
wifi.suspended is not inverse of wifi.enabled

Thank you vasanth for catching this. Your patch makes perfect sense to me: if wi-fi is disabled, I don’t see why it should be enabled when turning the airplane mode on and off again, or when rebooting the device.

If UX wasn’t NI’ed I’d have merged it already. :-)
Pinging Fernando in case he has anything to object, as he wrote the related lines in wifi.js.
Attachment #765794 - Flags: review?(kaze)
Attachment #765794 - Flags: review+
Attachment #765794 - Flags: feedback?(ferjmoreno)

Comment 6

5 years ago
Adding Casey to needinfo even though this is not blocking. Blockers still get priority.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(kyee)
Comment on attachment 765794 [details] [diff] [review]
wifi.suspended is not inverse of wifi.enabled

Review of attachment 765794 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me. Thanks!
Attachment #765794 - Flags: feedback?(ferjmoreno) → feedback+
(Assignee)

Comment 8

5 years ago
Thanks Fabian Cazenave and Fernando. Can we get to the closure of this?
Merged on master (I’m pretty sure UX will be OK… Casey, kick me if I’m wrong):
https://github.com/mozilla-b2g/gaia/commit/16a53406188b5b0819535b434d24dba4c0329c12
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
It's fine :)  thanks for the fix folks.
Flags: needinfo?(kyee)

Updated

5 years ago
blocking-b2g: leo? → -

Updated

4 years ago
Assignee: nobody → vasanth
You need to log in before you can comment on or make changes to this bug.