Closed Bug 885678 Opened 11 years ago Closed 11 years ago

Write unit tests for the renderer

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: janjongboom, Assigned: janjongboom)

Details

Attachments

(1 file)

Pointer to pull request
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review 
The renderUI function is a black box at the moment even though regressions happen there (twice this week). We'll need some testing around it.
Assignee: nobody → janjongboom
Here are 8 tests. 3 are failing at the moment. djf's patch regarding the _keyArray will solve two of them, and I'll create an issue for the last one.
Attachment #765862 - Flags: review?(dflanagan)
Added a bunch more, all tests now pass against master.
Attachment #765862 - Flags: review?(dflanagan) → review?(rlu)
This is really cool. Jan.
However, sorry that I might not be able to get to this right now due to some leo+ bugs that I am working on.

Will try to review this one ASAP after handling the leo+ bugs.
Thanks.
Cool. It's pretty low impact. Just tests, plus travis build succeeds as well.
Comment on attachment 765862 [details] [review]
Pointer to pull request

I just looked over the tests and ran a local test.
It looks great to me, r+.

Jan, thanks a lot.
Attachment #765862 - Flags: review?(rlu) → review+
Landed in https://github.com/mozilla-b2g/gaia/commit/1949b5745b1fcda8600c544370e7162f136df4c8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: