885719 - "Remix" from Tools page should only load templates from selected tool

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Laura Hilliger [:epilepticrabbit]]

https://webmaker.org/tools 

Reported by user:

https://webmaker.org/tools shows Popcorn and Thimble, and it says to start from scratch or remix, when you click on the remix for Popcorn, it seems to give you the Thimble templates – this is confusing for the user

Comment 1

[Ali Al Dallal [:alicoding]]

Perhaps we can also make a search result for a specific template, so that when they click on remix on thimble then it only displays the thimble template

Comment 2

[Laura Hilliger [:epilepticrabbit]]

Checking status here. 

I have mentors needing/wanting to link only to Thimble or only to Popcorn makes. Can't search by tag, is there a search workaround I can share?

Comment 3

[Jon Buckley [:jbuck]]

Dale, I don't suppose there's an app tag we can add here, is there?

Comment 4

[Dale Karp (:daleee)]

(In reply to Jon Buckley [:jbuck] from comment #3)
> Dale, I don't suppose there's an app tag we can add here, is there?

App tag, no. There *is* contentType as an option when using the makeAPI client to perform a search:

eg: contentType: "application/x-popcorn

This is how we use the filter on the front page, so I don't see why we couldn't use contentType to get only popcorn or thimble makes.

Comment 5

[Dale Karp (:daleee)]

Attachment: Code Review

https://github.com/mozilla/webmaker.org/pull/279

Comment 6

[Dale Karp (:daleee)]

Updated PR, ready for another pass:

https://github.com/mozilla/webmaker.org/pull/279

Comment 7

[inactivate account for kate]

Comment on attachment 778523 [details] [review]
Code Review

One more nit

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/5238aebf8401775a799c059ee273fae61042a943
[bug 885719] tools remix now sends user to correct search page

https://github.com/mozilla/webmaker.org/commit/1384e3c352f7c04816cea05fdaa2019cddef971d
Merge pull request #279 from daleee/885719-tools-remix-buttons-sends-to-proper-page

[bug 885719] tools remix now sends user to correct search page