Closed Bug 885784 Opened 6 years ago Closed 6 years ago
disable mozdevice tests
https://tbpl.mozilla.org/php/getParsedLog.php?id=24427195&tree=Mozilla-Central Well, our tests are unreliable. Big surprise. Lets disable the beasts unless we want to resolve bug 790765 as incomplete or what not.
to be landed on mozbase and m-c. the patch is against mozbase; if a separate patch/review is needed for m-c, lemme know
Attachment #765961 - Flags: review?(jgriffin)
Attachment #765961 - Flags: review?(jgriffin) → review+
err that was in comment 0 anyway, oh well :-)
irc://irc.mozilla.org/#ateam 10:15 < jhammel> jgriffin, ahal, mcote : so inbound is closed and i'm on a train and will be off soon 10:15 < jhammel> i.e. i can't/shouldn't push currently 10:16 <@jgriffin> jhammel: ok, I'll push it later 10:16 < jhammel> jgriffin: thanks
Obviously this is a complete sledgehammer, but I resorted to this for a few reasons: - not sure if this is the only test that fails; assuming it is, we can just disable that test like civilized people - instead of commenting out the inclusion, it should look more like: """ [incude:mozdevice/tests/manifest.ini] disabled = https://bugzilla.mozilla.org/show_bug.cgi?id=885784 """ However, there's no good expedient way of ensuring that all subsets are disabled...I think. Lemme comment on that later. - since make check is a critical path of failure, this needs to be disabled now. in emergencies, i tend to resort to sledgehammers that are assured success vs a researched solution
Assignee: nobody → jhammel
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
(In reply to Jeff Hammel [:jhammel] from comment #5) <snip/> > - instead of commenting out the inclusion, it should look more like: > > """ > [incude:mozdevice/tests/manifest.ini] > disabled = https://bugzilla.mozilla.org/show_bug.cgi?id=885784 > """ > > However, there's no good expedient way of ensuring that all subsets are > disabled...I think. Lemme comment on that later. Reading the code, this is in fact untrue: https://github.com/mozilla/mozbase/blob/master/manifestdestiny/manifestparser/manifestparser.py#L693 Perhasp worth documenting. In short, 'disabled = reason' wins.
You need to log in before you can comment on or make changes to this bug.