885804 - Rename (De)allocPFoo functions to (De)allocPFoo(Parent|Child)

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Benjamin Smedberg]

Why?

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Part 1: Change the IPDL codegen

Comment 3

[David Zbarsky (:dzbarsky)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Why?

I want to make PContentChild alloc both a PBrowserChild and a PBrowserParent.

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Part 2: content/dom changes

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: Part 3: gfx changes

Comment 6

[David Zbarsky (:dzbarsky)]

Attachment: Part 4: netwerk chances

Comment 7

[David Zbarsky (:dzbarsky)]

Attachment: Part 5: js, layout, ipc changes

Comment 8

[David Zbarsky (:dzbarsky)]

Attachment: Part 6: Blob changes

Comment 9

[David Zbarsky (:dzbarsky)]

Attachment: Part 7: IPDL unit test changes

Comment 10

[Benjamin Smedberg]

Comment on attachment 766073 [details] [diff] [review]
Part 4: netwerk chances

I'm not the right reviewer for this, please ask a necko peer.

Comment 11

[David Zbarsky (:dzbarsky)]

Comment on attachment 765988 [details] [diff] [review]
Part 1: Change the IPDL codegen

Review of attachment 765988 [details] [diff] [review]:
-----------------------------------------------------------------

Whoever gets to it first...

Comment 12

[Justin Lebar (not reading bugmail)]

Comment on attachment 766077 [details] [diff] [review]
Part 6: Blob changes

>diff --git a/dom/ipc/Blob.h b/dom/ipc/Blob.h
>--- a/dom/ipc/Blob.h
>+++ b/dom/ipc/Blob.h

>@@ -78,16 +78,22 @@ struct BlobTraits<Parent>
> 
>     static void
>     SetBlobConstructorParams(OtherSideConstructorParamsType& aParams,
>                              const ChildBlobConstructorParams& aBlobParams)
>     {
>       aParams = aBlobParams;
>     }
> 
>+    virtual StreamType*
>+    AllocPBlobStreamParent() MOZ_OVERRIDE;
>+
>+    virtual bool
>+    DeallocPBlobStreamParent(StreamType* aActor) MOZ_OVERRIDE;
>+
>   protected:
>     BaseType();
>     virtual ~BaseType();
> 
>     class OpenStreamRunnable;
>     friend class OpenStreamRunnable;
> 
>     void

>@@ -127,16 +133,22 @@ struct BlobTraits<Child>
>     static void
>     SetBlobConstructorParams(OtherSideConstructorParamsType& aParams,
>                              const ChildBlobConstructorParams& aBlobParams)
>     {
>       aParams.blobParams() = aBlobParams;
>       aParams.optionalInputStreamParams() = mozilla::void_t();
>     }
> 
>+    virtual StreamType*
>+    AllocPBlobStreamChild() MOZ_OVERRIDE;
>+
>+    virtual bool
>+    DeallocPBlobStreamChild(StreamType* aActor) MOZ_OVERRIDE;
>+
>   protected:
>     BaseType()
>     { }
> 
>     virtual ~BaseType()
>     { }
>   };
> };

This change makes the alloc/dealloc methods public, while they used to be
private.

Should they be protected on BlobTraits instead?

Comment 13

[David Zbarsky (:dzbarsky)]

(In reply to Justin Lebar [:jlebar] from comment #12)
> Comment on attachment 766077 [details] [diff] [review]
> Part 6: Blob changes

> 
> This change makes the alloc/dealloc methods public, while they used to be
> private.
> 
> Should they be protected on BlobTraits instead?

Yes, they should.  Thank you!

Comment 14

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e5031425fa8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d1cdcb9c3aa
https://hg.mozilla.org/integration/mozilla-inbound/rev/4904744398e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/c830132a6a73
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a1eb825afe3
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c60785ea720
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb4f5079e009

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e5031425fa8
https://hg.mozilla.org/mozilla-central/rev/2d1cdcb9c3aa
https://hg.mozilla.org/mozilla-central/rev/4904744398e7
https://hg.mozilla.org/mozilla-central/rev/c830132a6a73
https://hg.mozilla.org/mozilla-central/rev/9a1eb825afe3
https://hg.mozilla.org/mozilla-central/rev/1c60785ea720
https://hg.mozilla.org/mozilla-central/rev/bb4f5079e009