Closed Bug 885804 Opened 7 years ago Closed 7 years ago

Rename (De)allocPFoo functions to (De)allocPFoo(Parent|Child)

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(7 files)

No description provided.
Why?
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #765988 - Flags: review?(bent.mozilla)
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Why?

I want to make PContentChild alloc both a PBrowserChild and a PBrowserParent.
Attachment #766060 - Flags: review?(bent.mozilla)
Attachment #766065 - Flags: review?(nical.bugzilla)
Attachment #766073 - Flags: review?(benjamin)
Attachment #766074 - Flags: review?(benjamin)
Attachment #766077 - Flags: review?(bent.mozilla)
Blocks: 885653
Attachment #766065 - Flags: review?(nical.bugzilla) → review+
Attachment #766506 - Flags: review?(benjamin)
Comment on attachment 766073 [details] [diff] [review]
Part 4: netwerk chances

I'm not the right reviewer for this, please ask a necko peer.
Attachment #766073 - Flags: review?(benjamin)
Attachment #766074 - Flags: review?(benjamin)
Attachment #766506 - Flags: review?(benjamin) → review+
Attachment #766074 - Flags: review?(roc)
Attachment #766073 - Flags: review?(jduell.mcbugs)
Attachment #766073 - Flags: review?(jduell.mcbugs) → review+
Comment on attachment 765988 [details] [diff] [review]
Part 1: Change the IPDL codegen

Review of attachment 765988 [details] [diff] [review]:
-----------------------------------------------------------------

Whoever gets to it first...
Attachment #765988 - Flags: review?(justin.lebar+bug)
Attachment #766060 - Flags: review?(justin.lebar+bug)
Attachment #766077 - Flags: review?(justin.lebar+bug)
Attachment #765988 - Flags: review?(justin.lebar+bug)
Attachment #765988 - Flags: review?(bent.mozilla)
Attachment #765988 - Flags: review+
Attachment #766060 - Flags: review?(justin.lebar+bug)
Attachment #766060 - Flags: review?(bent.mozilla)
Attachment #766060 - Flags: review+
Comment on attachment 766077 [details] [diff] [review]
Part 6: Blob changes

>diff --git a/dom/ipc/Blob.h b/dom/ipc/Blob.h
>--- a/dom/ipc/Blob.h
>+++ b/dom/ipc/Blob.h

>@@ -78,16 +78,22 @@ struct BlobTraits<Parent>
> 
>     static void
>     SetBlobConstructorParams(OtherSideConstructorParamsType& aParams,
>                              const ChildBlobConstructorParams& aBlobParams)
>     {
>       aParams = aBlobParams;
>     }
> 
>+    virtual StreamType*
>+    AllocPBlobStreamParent() MOZ_OVERRIDE;
>+
>+    virtual bool
>+    DeallocPBlobStreamParent(StreamType* aActor) MOZ_OVERRIDE;
>+
>   protected:
>     BaseType();
>     virtual ~BaseType();
> 
>     class OpenStreamRunnable;
>     friend class OpenStreamRunnable;
> 
>     void

>@@ -127,16 +133,22 @@ struct BlobTraits<Child>
>     static void
>     SetBlobConstructorParams(OtherSideConstructorParamsType& aParams,
>                              const ChildBlobConstructorParams& aBlobParams)
>     {
>       aParams.blobParams() = aBlobParams;
>       aParams.optionalInputStreamParams() = mozilla::void_t();
>     }
> 
>+    virtual StreamType*
>+    AllocPBlobStreamChild() MOZ_OVERRIDE;
>+
>+    virtual bool
>+    DeallocPBlobStreamChild(StreamType* aActor) MOZ_OVERRIDE;
>+
>   protected:
>     BaseType()
>     { }
> 
>     virtual ~BaseType()
>     { }
>   };
> };

This change makes the alloc/dealloc methods public, while they used to be
private.

Should they be protected on BlobTraits instead?
Attachment #766077 - Flags: review?(justin.lebar+bug)
Attachment #766077 - Flags: review?(bent.mozilla)
Attachment #766077 - Flags: review+
(In reply to Justin Lebar [:jlebar] from comment #12)
> Comment on attachment 766077 [details] [diff] [review]
> Part 6: Blob changes

> 
> This change makes the alloc/dealloc methods public, while they used to be
> private.
> 
> Should they be protected on BlobTraits instead?

Yes, they should.  Thank you!
You need to log in before you can comment on or make changes to this bug.