Add automatic regex creation to GCLI appcache command tests

RESOLVED FIXED in Firefox 32

Status

defect
RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: miker, Assigned: miker)

Tracking

unspecified
Firefox 32
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The appcache command tests use hardcoded strings to test appcache output. This results in possible errors when strings are changed in appcacheutils.properties.

We should use a getRegexFromStringName() method and use the localized strings for comparison.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
No longer depends on: 909681
Depends on: 981758
No longer depends on: 882337
I called the method getRegexForString() and it does greatly simplify the test.
Attachment #8416555 - Flags: review?(pbrosset)
Comment on attachment 8416555 [details] [diff] [review]
automatic-regex-creation-for-appcache-tests-885806.patch

Review of attachment 8416555 [details] [diff] [review]:
-----------------------------------------------------------------

Cool!
Attachment #8416555 - Flags: review?(pbrosset) → review+
https://hg.mozilla.org/mozilla-central/rev/365fc5eb1169
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.