A specific youtube clip ends before it says it ends

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Something about this clip causes it to end early.

http://www.youtube.com/watch?v=swT1uSSUVUc

You can see it in both popcorn maker and on youtube's own page.

Seems like duration data is reporting a number that is after the ended event.

This is a good reproducible link and I am glad I found it. It exposes a bug I have not been able to reproduce before.
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

5 years ago
I don't think we can solve this in a good way on our end.

I filed it here in hopes at the least, more info, at the most a fix: http://code.google.com/p/gdata-issues/issues/detail?id=4807&thanks=4807&ts=1372174729

What I can tell you is that the youtube wrapper thinks it has ended before the reported duration is hit. When we try to sequence these and line them up, we use the duration data to know when it is going to end. If it is wrong there is no way we can reliably sequence up.

Let's see if the bug I filed shakes anything out before I add a hack.

Keep in mind this problem is also before it hits sequencer. We emulate html with our youtube wrapper, so an ended event is a real thing, and it also has expected functionality, which is to end the video and fire a paused event if loop is false.

An ended event doesn't mean anything in a sequence, we should keep playing. We cover this by not letting the sequence track event to be greater than the reported duration, just equal to. It never actually ends.

I can add a hack that, from inside the seqencer, if I ever hit an ended event in a sequence and we were playing, to play again. There would be a noticable blip, though.
(Assignee)

Comment 2

5 years ago
I think I have a handle on this now.

I prototyped it yesterday and got it working.

Needs a fix in the YouTube wrapper first.

Filed and fixed it here: bug 890068
(Assignee)

Updated

5 years ago
Depends on: 890068
(Assignee)

Updated

5 years ago
Blocks: 889848
(Assignee)

Comment 4

5 years ago
When you test this, take a moment to test bug 889848 with this patch, I did, and it's fixing it on my end.
Comment on attachment 772086 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/96

R+ with review comments addressed.
Attachment #772086 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 772086 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/96

Updated.

Might as well take another quick look.
Attachment #772086 - Flags: review+ → review?(schranz.m)
Attachment #772086 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 7

5 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/9b2938914e400c1ac117f876373a4cdf6d563b99
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.