885906 - Remove .sh and .pl catch anything implicit rules

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

I was playing with |make -dr| and noticed we have a few catch anything implicit rules in rules.mk:

%:: %.pl
	$(RM) $@
	cp $< $@
	chmod +x $@

%:: %.sh
	$(RM) $@
	cp $< $@
	chmod +x $@

It appears the origins of these lines are from the initial CVS commit. They were touched in bug 480069 and on an earlier commit in 2000 which dealt with OS/2 compatibility.

I'm fairly certain we can delete these rules without consequence (famous last words).

This is similar to bug 418593, but more tightly scoped.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Gregory Szorc [:gps] from comment #0)
> I'm fairly certain we can delete these rules without consequence (famous
> last words).

r=me!

Comment 2

[Gregory Szorc [:gps]]

Attachment: Remove .sh and .pl catch anything implicit rules

Giving to bsmedberg since this is from the CVS days :)

Try at https://tbpl.mozilla.org/?tree=Try&rev=a9bafffe58eb

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 766125 [details] [diff] [review]
Remove .sh and .pl catch anything implicit rules

khuey seemed to review patch. I'll have to scheme another way to get bsmedberg to review a build patch...

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f16505fc85e

Not sure if this will actually make the build faster. But it certainly won't hurt.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9f16505fc85e