885941 - Please update all links in Firefox for Android privacy policy to redirect to https://www.mozilla.org/en-US/legal/privacy/firefox.html

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jishnu Menon :jishnu]

Hi - 

There are several linked privacy policies in Fennec - all should point to https://www.mozilla.org/en-US/legal/privacy/firefox.html (except in Health Report which should go to the specific section in the same policy).

Comment 1

[Aaron Train [:aaronmt]]

Is this bug referring to the URL assigned to app.privacyURL?

Comment 2

[:Margaret Leibovic]

We did update the link in about:rights in bug 874888, but Aaron is correct that we need to update the app.privacyURL pref, which is used in about:firefox.

Jishnu, do you know of any other in-product privacy links we may have missed?

I'm going to steal this as a good first bug for the intern we have starting today.

Comment 3

[Chris Kitching [:ckitching]]

Attachment: Patch homogenising privacy links

The actual URL we´re after here is `https://www.mozilla.org/legal/privacy/firefox.html`, as the website does slightly clever redirection to go to the appropriate locale (And we don´t want to redirect everyone to the en-US version).
There was one incorrect URL - patch attached.

Comment 4

[:Margaret Leibovic]

Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

(When requesting review, you should specify a reviewer. In this case, it's me :)

Comment 5

[:Margaret Leibovic]

Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

Looks good to me!

Comment 6

[:Margaret Leibovic]

I'm setting the checkin-needed keyword on this bug, which means that a kind soul with commit access will come along and land this patch for you :)

Comment 7

[Chris Kitching [:ckitching]]

Thanks - I did add you as the reviewer, but I used your email address not your name, causing bugzilla to blithley inform me itś truncated the field and carried on. Whoops.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e41ddaef7c0

Comment 9

[:Margaret Leibovic]

(In reply to Chris Kitching from comment #7)
> Thanks - I did add you as the reviewer, but I used your email address not
> your name, causing bugzilla to blithley inform me itś truncated the field
> and carried on. Whoops.

You need to use the bugzilla id of the reviewer, which is an email address. Pro tip: Many people also add handle shortcuts to their name to make autocomplete easier (e.g. for me, you can just type ":marg" and I'll be the only result that comes up :).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4e41ddaef7c0

Comment 11

[Erin Lancaster [:elan]]

How uplift-able is this? I'm thinking since we are shipping FHR for the first time in Fx23, we might need this as far up as beta for consistency.

Comment 12

[:Margaret Leibovic]

(In reply to Erin Lancaster [:elancaster] from comment #11)
> How uplift-able is this? I'm thinking since we are shipping FHR for the
> first time in Fx23, we might need this as far up as beta for consistency.

This is totally upliftable, since it's a pref, not a string. Want me to request uplift?

(The patch for bug 874888 is also good to uplift, since the URL there is just hardcoded into some HTML.)

Comment 13

[Erin Lancaster [:elan]]

Yes, let's request uplift for both. (thank you!).

Comment 14

[:Margaret Leibovic]

Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this isn't a regression, but we'd like to uplift it because FHR will be part of 23, and we want users to be able to access privacy policies easily
User impact if declined: privacy policies are incorrectly linked
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low risk, just updates a link URL
String or IDL/UUID changes made by this patch: n/a

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bfc39992335f
https://hg.mozilla.org/releases/mozilla-beta/rev/f35c9d86cc1a

Comment 16

[u421692]

Verified fixed on:
Build: 
Firefox for Android 25.0a1(2013-07-18)
Firefox for Android 24.0a2
Firefox for Android 23.0b2

Device: LG Nexus 4
OS: Android 4.2.2