Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Please update all links in Firefox for Android privacy policy to redirect to https://www.mozilla.org/en-US/legal/privacy/firefox.html

VERIFIED FIXED in Firefox 23

Status

()

Firefox for Android
General
VERIFIED FIXED
4 years ago
a year ago

People

(Reporter: jishnu, Assigned: ckitching)

Tracking

unspecified
Firefox 25
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox23 verified, firefox24 verified, firefox25 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Hi - 

There are several linked privacy policies in Fennec - all should point to https://www.mozilla.org/en-US/legal/privacy/firefox.html (except in Health Report which should go to the specific section in the same policy).
Is this bug referring to the URL assigned to app.privacyURL?
See Also: → bug 874888

Comment 2

4 years ago
We did update the link in about:rights in bug 874888, but Aaron is correct that we need to update the app.privacyURL pref, which is used in about:firefox.

Jishnu, do you know of any other in-product privacy links we may have missed?

I'm going to steal this as a good first bug for the intern we have starting today.
Assignee: nobody → margaret.leibovic
OS: Mac OS X → Android
Hardware: x86 → ARM

Updated

4 years ago
Blocks: 885895

Updated

4 years ago
Assignee: margaret.leibovic → ckitching
(Assignee)

Comment 3

4 years ago
Created attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

The actual URL we´re after here is `https://www.mozilla.org/legal/privacy/firefox.html`, as the website does slightly clever redirection to go to the appropriate locale (And we don´t want to redirect everyone to the en-US version).
There was one incorrect URL - patch attached.
Attachment #767507 - Flags: review?

Comment 4

4 years ago
Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

(When requesting review, you should specify a reviewer. In this case, it's me :)
Attachment #767507 - Flags: review? → review?(margaret.leibovic)

Comment 5

4 years ago
Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

Looks good to me!
Attachment #767507 - Flags: review?(margaret.leibovic) → review+

Comment 6

4 years ago
I'm setting the checkin-needed keyword on this bug, which means that a kind soul with commit access will come along and land this patch for you :)
Keywords: checkin-needed
(Assignee)

Comment 7

4 years ago
Thanks - I did add you as the reviewer, but I used your email address not your name, causing bugzilla to blithley inform me itś truncated the field and carried on. Whoops.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e41ddaef7c0
Keywords: checkin-needed

Comment 9

4 years ago
(In reply to Chris Kitching from comment #7)
> Thanks - I did add you as the reviewer, but I used your email address not
> your name, causing bugzilla to blithley inform me itś truncated the field
> and carried on. Whoops.

You need to use the bugzilla id of the reviewer, which is an email address. Pro tip: Many people also add handle shortcuts to their name to make autocomplete easier (e.g. for me, you can just type ":marg" and I'll be the only result that comes up :).
https://hg.mozilla.org/mozilla-central/rev/4e41ddaef7c0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
How uplift-able is this? I'm thinking since we are shipping FHR for the first time in Fx23, we might need this as far up as beta for consistency.

Comment 12

4 years ago
(In reply to Erin Lancaster [:elancaster] from comment #11)
> How uplift-able is this? I'm thinking since we are shipping FHR for the
> first time in Fx23, we might need this as far up as beta for consistency.

This is totally upliftable, since it's a pref, not a string. Want me to request uplift?

(The patch for bug 874888 is also good to uplift, since the URL there is just hardcoded into some HTML.)
Yes, let's request uplift for both. (thank you!).

Comment 14

4 years ago
Comment on attachment 767507 [details] [diff] [review]
Patch homogenising privacy links

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this isn't a regression, but we'd like to uplift it because FHR will be part of 23, and we want users to be able to access privacy policies easily
User impact if declined: privacy policies are incorrectly linked
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low risk, just updates a link URL
String or IDL/UUID changes made by this patch: n/a
Attachment #767507 - Flags: approval-mozilla-beta?
Attachment #767507 - Flags: approval-mozilla-aurora?
Attachment #767507 - Flags: approval-mozilla-beta?
Attachment #767507 - Flags: approval-mozilla-beta+
Attachment #767507 - Flags: approval-mozilla-aurora?
Attachment #767507 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/bfc39992335f
https://hg.mozilla.org/releases/mozilla-beta/rev/f35c9d86cc1a
status-firefox23: --- → fixed
status-firefox24: --- → fixed
status-firefox25: --- → fixed

Comment 16

4 years ago
Verified fixed on:
Build: 
Firefox for Android 25.0a1(2013-07-18)
Firefox for Android 24.0a2
Firefox for Android 23.0b2

Device: LG Nexus 4
OS: Android 4.2.2
Status: RESOLVED → VERIFIED
status-firefox23: fixed → verified
status-firefox24: fixed → verified
status-firefox25: fixed → verified
You need to log in before you can comment on or make changes to this bug.