Closed Bug 885979 Opened 11 years ago Closed 7 years ago

Add support for enabling Contacts API debugging output at runtime

Categories

(Core Graveyard :: DOM: Contacts, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:-, firefox23 wontfix, firefox24 wontfix, firefox25 affected, b2g18 affected, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd affected)

RESOLVED WONTFIX
blocking-b2g -
Tracking Status
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- affected
b2g18 --- affected
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- affected

People

(Reporter: reuben, Assigned: reuben)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(4 files, 4 obsolete files)

Right now Contacts API debugging output is based on a compile-time constant. We constantly have to ask bug reporters to test with a debug-enabled build, and that's time consuming/not always possible.
Attached patch Patch (obsolete) — Splinter Review
Attachment #766761 - Flags: review?(anygregor)
Attached patch Gaia patch (obsolete) — Splinter Review
https://github.com/mozilla-b2g/gaia/pull/10581
Attachment #766766 - Flags: review?(anygregor)
Attached patch Gaia PatchSplinter Review
Attachment #766766 - Attachment is obsolete: true
Attachment #766766 - Flags: review?(anygregor)
Attachment #767062 - Flags: review?(ehung)
Attached patch Gecko Patch (obsolete) — Splinter Review
I fixed some binding problems.
Attachment #766761 - Attachment is obsolete: true
Attachment #766761 - Flags: review?(anygregor)
Comment on attachment 767062 [details] [diff] [review]
Gaia Patch

r=me, looks fine. Thanks!
Attachment #767062 - Flags: review?(ehung) → review+
Attached patch Gecko PatchSplinter Review
Attachment #767063 - Attachment is obsolete: true
Attachment #768178 - Flags: review?(anygregor)
Comment on attachment 768178 [details] [diff] [review]
Gecko Patch

Review of attachment 768178 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #768178 - Flags: review?(anygregor) → review+
Blocks: 880327
Blocks a blocker, so leo+ for uplift. Gregor & Reuben - please determine if this should be backed out after bug 880327 is fixed. If so, file another bug and I'll leo+ that one too ;)
blocking-b2g: --- → leo+
https://hg.mozilla.org/mozilla-central/rev/08185bc7ab8d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Backed out again for the same failure *and* a new leak!
https://hg.mozilla.org/releases/mozilla-b2g18/rev/6226eec68412
Attached patch b2g18 patch (obsolete) — Splinter Review
Comment on attachment 769467 [details] [diff] [review]
b2g18 patch

Review of attachment 769467 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/fallback/ContactService.jsm
@@ +105,3 @@
>        Services.prefs.removeObserver("dom.phonenumber.substringmatching", this);
>        ppmm = null;
> +      gSettingsService = null;

Ugh, really? Isn't this a bug in SettingsService?
Attached patch b2g18 prachSplinter Review
Sanity check.
Attachment #769467 - Attachment is obsolete: true
Attachment #769564 - Flags: review?(reuben.bmo)
Attachment #769564 - Flags: review?(reuben.bmo) → review+
aaaand backout.
Heaven for a try-server or a locally reproducible testfailure!

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5cddbe066fe9
Backed out for breaking unrelated Gaia apps:
https://hg.mozilla.org/projects/birch/rev/4e39baa045fd
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 888284
No longer blocks a blocker. Minusing.
blocking-b2g: leo+ → -
Component: DOM: Device Interfaces → DOM: Contacts
Gregor - we should remove this setting unless we actually are going to land this.
Attachment #8373562 - Flags: review?(anygregor)
Comment on attachment 8373562 [details] [review]
Pull request - Remove unused setting

Hm I thought it works.
Attachment #8373562 - Flags: review?(anygregor) → review?(reuben.bmo)
It did - but it was backed out a while ago, and now we have a dead setting :) Unless we plan on doing some major refactoring work - i would assume that we don't need this logging as we've gone a good 6 months without it.
Comment on attachment 8373562 [details] [review]
Pull request - Remove unused setting

Yep. This should have been backed out.
Attachment #8373562 - Flags: review?(reuben.bmo) → review+
This code no longer exists.
Status: REOPENED → RESOLVED
Closed: 11 years ago7 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: