Closed
Bug 885979
Opened 11 years ago
Closed 7 years ago
Add support for enabling Contacts API debugging output at runtime
Categories
(Core Graveyard :: DOM: Contacts, defect)
Tracking
(blocking-b2g:-, firefox23 wontfix, firefox24 wontfix, firefox25 affected, b2g18 affected, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd affected)
People
(Reporter: reuben, Assigned: reuben)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(4 files, 4 obsolete files)
2.48 KB,
patch
|
jj.evelyn
:
review+
|
Details | Diff | Splinter Review |
8.89 KB,
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
9.94 KB,
patch
|
reuben
:
review+
|
Details | Diff | Splinter Review |
46 bytes,
text/x-github-pull-request
|
reuben
:
review+
|
Details | Review |
Right now Contacts API debugging output is based on a compile-time constant. We constantly have to ask bug reporters to test with a debug-enabled build, and that's time consuming/not always possible.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #766761 -
Flags: review?(anygregor)
Assignee | ||
Comment 2•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/10581
Attachment #766766 -
Flags: review?(anygregor)
Comment 3•11 years ago
|
||
Attachment #766766 -
Attachment is obsolete: true
Attachment #766766 -
Flags: review?(anygregor)
Attachment #767062 -
Flags: review?(ehung)
Comment 4•11 years ago
|
||
I fixed some binding problems.
Attachment #766761 -
Attachment is obsolete: true
Attachment #766761 -
Flags: review?(anygregor)
Comment 5•11 years ago
|
||
Comment on attachment 767062 [details] [diff] [review] Gaia Patch r=me, looks fine. Thanks!
Attachment #767062 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #767063 -
Attachment is obsolete: true
Attachment #768178 -
Flags: review?(anygregor)
Comment 7•11 years ago
|
||
Comment on attachment 768178 [details] [diff] [review] Gecko Patch Review of attachment 768178 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #768178 -
Flags: review?(anygregor) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/08185bc7ab8d
Whiteboard: [fixed-in-birch]
Comment 9•11 years ago
|
||
Blocks a blocker, so leo+ for uplift. Gregor & Reuben - please determine if this should be backed out after bug 880327 is fixed. If so, file another bug and I'll leo+ that one too ;)
blocking-b2g: --- → leo+
Comment 10•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08185bc7ab8d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment 11•11 years ago
|
||
gaia merge: https://github.com/mozilla-b2g/gaia/commit/cc625a92e7662f0e53fc4375b42fb3d2a6628cfe
Assignee | ||
Comment 12•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bca4c537aaa3
Assignee | ||
Comment 13•11 years ago
|
||
…aaand backed out: https://hg.mozilla.org/releases/mozilla-b2g18/rev/36c70ca76cc7
Assignee | ||
Comment 14•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/d923b362bf50
Assignee | ||
Comment 15•11 years ago
|
||
Backed out again for the same failure *and* a new leak! https://hg.mozilla.org/releases/mozilla-b2g18/rev/6226eec68412
Comment 16•11 years ago
|
||
Assignee | ||
Comment 17•11 years ago
|
||
Comment on attachment 769467 [details] [diff] [review] b2g18 patch Review of attachment 769467 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/contacts/fallback/ContactService.jsm @@ +105,3 @@ > Services.prefs.removeObserver("dom.phonenumber.substringmatching", this); > ppmm = null; > + gSettingsService = null; Ugh, really? Isn't this a bug in SettingsService?
Comment 18•11 years ago
|
||
Sanity check.
Attachment #769467 -
Attachment is obsolete: true
Attachment #769564 -
Flags: review?(reuben.bmo)
Assignee | ||
Updated•11 years ago
|
Attachment #769564 -
Flags: review?(reuben.bmo) → review+
Comment 20•11 years ago
|
||
aaaand backout. Heaven for a try-server or a locally reproducible testfailure! https://hg.mozilla.org/releases/mozilla-b2g18/rev/5cddbe066fe9
Comment 21•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f76cd1f0a5e9
status-b2g-v1.1hd:
--- → affected
status-firefox23:
--- → wontfix
status-firefox24:
--- → wontfix
status-firefox25:
--- → fixed
Assignee | ||
Comment 22•11 years ago
|
||
Backed out for breaking unrelated Gaia apps: https://hg.mozilla.org/projects/birch/rev/4e39baa045fd
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 23•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4e39baa045fd
Target Milestone: mozilla25 → ---
Updated•11 years ago
|
Component: DOM: Device Interfaces → DOM: Contacts
Comment 25•10 years ago
|
||
Gregor - we should remove this setting unless we actually are going to land this.
Attachment #8373562 -
Flags: review?(anygregor)
Comment 26•10 years ago
|
||
Comment on attachment 8373562 [details] [review] Pull request - Remove unused setting Hm I thought it works.
Attachment #8373562 -
Flags: review?(anygregor) → review?(reuben.bmo)
Comment 27•10 years ago
|
||
It did - but it was backed out a while ago, and now we have a dead setting :) Unless we plan on doing some major refactoring work - i would assume that we don't need this logging as we've gone a good 6 months without it.
Assignee | ||
Comment 28•10 years ago
|
||
Comment on attachment 8373562 [details] [review] Pull request - Remove unused setting Yep. This should have been backed out.
Attachment #8373562 -
Flags: review?(reuben.bmo) → review+
Comment 29•10 years ago
|
||
Landed revert of contact setting: https://github.com/mozilla-b2g/gaia/commit/33fe27aa3c60ccf312f35da0edc1b1918780379f
Assignee | ||
Comment 30•7 years ago
|
||
This code no longer exists.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 7 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•