Closed
Bug 886015
Opened 8 years ago
Closed 8 years ago
Console js input looks broken on OS X
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: vporof, Assigned: Optimizer)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(3 files, 1 obsolete file)
111.50 KB,
image/png
|
Details | |
1.03 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
915 bytes,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Maybe because bug 884887.
Assignee | ||
Comment 1•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2fd3d3b584d8#l6.231 reverted back the console's arrow to the old image which is now not present. The patch fixes that.
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 766295 [details] [diff] [review] revert back to correct url Race.
Attachment #766295 -
Flags: review?(mihai.sucan)
Comment 3•8 years ago
|
||
Comment on attachment 766295 [details] [diff] [review] revert back to correct url I know I did this in my patch for Bug 884887 - 100% sure, because I did check what you changed. Maybe I failed to save the change... Thanks for the catch and for the fix!
Attachment #766295 -
Flags: review?(mihai.sucan) → review+
Reporter | ||
Updated•8 years ago
|
Attachment #766295 -
Flags: review?(vporof)
Comment 4•8 years ago
|
||
This adds the .jsterm-input-container background:white styling bac for macos. Should we add it for the other systems as well? It wasn't there for the others...
Attachment #766312 -
Flags: review?(vporof)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 766312 [details] [diff] [review] fix for the input background Review of attachment 766312 [details] [diff] [review]: ----------------------------------------------------------------- I don't think this is the right patch :) And, yes, I believe the white background should be added to all platforms, because the styling issues exists on all platforms.
Attachment #766312 -
Flags: review?(vporof)
Comment 6•8 years ago
|
||
Hah, I attached the wrong patch. This should be the correct one. Also, I moved jsterm-input-container background:white to shared/webconsole.inc.css as requested.
Attachment #766312 -
Attachment is obsolete: true
Attachment #766344 -
Flags: review?(vporof)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 766344 [details] [diff] [review] fix for the input background - the correct patch Review of attachment 766344 [details] [diff] [review]: ----------------------------------------------------------------- Yup!
Attachment #766344 -
Flags: review?(vporof) → review+
Reporter | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7f1392bacb9f https://hg.mozilla.org/integration/fx-team/rev/4f03fbc6f5fd
Reporter | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f1392bacb9f https://hg.mozilla.org/mozilla-central/rev/4f03fbc6f5fd
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Updated•8 years ago
|
Target Milestone: --- → Firefox 24
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•