Closed Bug 886015 Opened 7 years ago Closed 7 years ago

Console js input looks broken on OS X

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: vporof, Assigned: Optimizer)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 files, 1 obsolete file)

Attached image screenshot
Maybe because bug 884887.
https://hg.mozilla.org/integration/fx-team/rev/2fd3d3b584d8#l6.231 reverted back the console's arrow to the old image which is now not present.

The patch fixes that.
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #766295 - Flags: review?(vporof)
Comment on attachment 766295 [details] [diff] [review]
revert back to correct url

Race.
Attachment #766295 - Flags: review?(mihai.sucan)
Comment on attachment 766295 [details] [diff] [review]
revert back to correct url

I know I did this in my patch for Bug 884887 - 100% sure, because I did check what you changed. Maybe I failed to save the change...

Thanks for the catch and for the fix!
Attachment #766295 - Flags: review?(mihai.sucan) → review+
Attachment #766295 - Flags: review?(vporof)
Attached patch fix for the input background (obsolete) — Splinter Review
This adds the .jsterm-input-container background:white styling bac for macos. Should we add it for the other systems as well? It wasn't there for the others...
Attachment #766312 - Flags: review?(vporof)
Comment on attachment 766312 [details] [diff] [review]
fix for the input background

Review of attachment 766312 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is the right patch :)
And, yes, I believe the white background should be added to all platforms, because the styling issues exists on all platforms.
Attachment #766312 - Flags: review?(vporof)
Hah, I attached the wrong patch. This should be the correct one. Also, I moved jsterm-input-container background:white to shared/webconsole.inc.css as requested.
Attachment #766312 - Attachment is obsolete: true
Attachment #766344 - Flags: review?(vporof)
Comment on attachment 766344 [details] [diff] [review]
fix for the input background - the correct patch

Review of attachment 766344 [details] [diff] [review]:
-----------------------------------------------------------------

Yup!
Attachment #766344 - Flags: review?(vporof) → review+
Target Milestone: --- → Firefox 24
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.