886015 - Console js input looks broken on OS X

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

Maybe because bug 884887.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: revert back to correct url

https://hg.mozilla.org/integration/fx-team/rev/2fd3d3b584d8#l6.231 reverted back the console's arrow to the old image which is now not present.

The patch fixes that.

Comment 2

[Girish Sharma [:Optimizer]]

Comment on attachment 766295 [details] [diff] [review]
revert back to correct url

Race.

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 766295 [details] [diff] [review]
revert back to correct url

I know I did this in my patch for Bug 884887 - 100% sure, because I did check what you changed. Maybe I failed to save the change...

Thanks for the catch and for the fix!

Comment 4

[Mihai Sucan [:msucan]]

Attachment: fix for the input background

This adds the .jsterm-input-container background:white styling bac for macos. Should we add it for the other systems as well? It wasn't there for the others...

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 766312 [details] [diff] [review]
fix for the input background

Review of attachment 766312 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is the right patch :)
And, yes, I believe the white background should be added to all platforms, because the styling issues exists on all platforms.

Comment 6

[Mihai Sucan [:msucan]]

Attachment: fix for the input background - the correct patch

Hah, I attached the wrong patch. This should be the correct one. Also, I moved jsterm-input-container background:white to shared/webconsole.inc.css as requested.

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 766344 [details] [diff] [review]
fix for the input background - the correct patch

Review of attachment 766344 [details] [diff] [review]:
-----------------------------------------------------------------

Yup!

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/7f1392bacb9f
https://hg.mozilla.org/integration/fx-team/rev/4f03fbc6f5fd

Comment 9

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/7f1392bacb9f
https://hg.mozilla.org/mozilla-central/rev/4f03fbc6f5fd