886028 - Label "All-day Events" is not localized

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Francesco Lodolo [:flod]]

Currently using Unagi set to Italian, last updated on Jun 19.

See screenshot, "All-day Events" is not localized.

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L283
data-l10n-id = "all-day-events"

The correct id is allday-events
https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/calendar.en-US.properties#L9

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Screenshot of unlocalized string (Unagi)

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10550/files

Pointer to Github pull-request

Comment 3

[James Lal [:lightsofapollo]]

in master https://github.com/mozilla-b2g/gaia/commit/14367fe868af13c63548d57fd1e2dea0134e65fa

Comment 4

[Jason Smith [:jsmith]]

Does this affect b2g18?

Comment 5

[Francesco Lodolo [:flod]]

Adding blocking-b2g->leo? since it involves v1-train to
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/calendar/index.html#L282

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 14367fe868af13c63548d57fd1e2dea0134e65fa to:
v1-train: 7c20b4f8b188a11c3e18204e36a35ff664e49c40

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 7c20b4f8b188a11c3e18204e36a35ff664e49c40

Comment 10

[Francesco Lodolo [:flod]]

Verified on Unagi, build ID 20130701070213

Comment 11

[mdaniloff]

"All Day Events" is localized in all languages

Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1