886052 - Audio getUserMedia webrtc trace logging isn't enabled

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Turn on Audio GUM logs

getUserMedia()'s audio capture code doesn't enable webrtc_trace logging, though video is enabled.

To test, see if you get AUDIO DEVICE logs when setting NSPR_LOG_MODULES=webrtc_trace:65535 and WEBRTC_TRACE_FILE=whatever and capturing audio with GUM.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 766347 [details] [diff] [review]
Turn on Audio GUM  logs

Review of attachment 766347 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webrtc/MediaEngineWebRTC.cpp
@@ +247,5 @@
>        return;
>      }
>    }
>  
> +  //Per WebRTC APIs below function calls return NULL on failure

Which function callS? There's only 1 here that returns anything.

::: media/webrtc/signaling/src/common/browser_logging/CSFLog.h
@@ +61,5 @@
>  #ifdef __cplusplus
>  }
>  #endif
>  
>  #endif

Spurious whitespace change?

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75832c5047a4

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/75832c5047a4