Closed
Bug 886052
Opened 11 years ago
Closed 11 years ago
Audio getUserMedia webrtc trace logging isn't enabled
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jesup, Assigned: jesup)
Details
(Whiteboard: [getUserMedia] [blocking-gum-])
Attachments
(1 file)
1.75 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
getUserMedia()'s audio capture code doesn't enable webrtc_trace logging, though video is enabled. To test, see if you get AUDIO DEVICE logs when setting NSPR_LOG_MODULES=webrtc_trace:65535 and WEBRTC_TRACE_FILE=whatever and capturing audio with GUM.
Attachment #766347 -
Flags: review?(tterribe)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [getUserMedia] [blocking-gum-]
Assignee | ||
Updated•11 years ago
|
Attachment #766347 -
Flags: review?(tterribe) → review?(gpascutto)
Comment 1•11 years ago
|
||
Comment on attachment 766347 [details] [diff] [review] Turn on Audio GUM logs Review of attachment 766347 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/webrtc/MediaEngineWebRTC.cpp @@ +247,5 @@ > return; > } > } > > + //Per WebRTC APIs below function calls return NULL on failure Which function callS? There's only 1 here that returns anything. ::: media/webrtc/signaling/src/common/browser_logging/CSFLog.h @@ +61,5 @@ > #ifdef __cplusplus > } > #endif > > #endif Spurious whitespace change?
Attachment #766347 -
Flags: review?(gpascutto) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75832c5047a4
Target Milestone: --- → mozilla27
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75832c5047a4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•