Closed Bug 886088 Opened 6 years ago Closed 6 years ago

Refine Telemetry of third party cookies in private browsing mode

Categories

(Core :: Networking: Cookies, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(1 file, 1 obsolete file)

It seems that, in private browsing mode, we do not have access to referrer URIs for cookies. We should revisit the patch of bug 837326 and ensure that this does not impact our telemetry.
We might want to stop measuring entirely when people are in private mode since the cookie behavior is different.
(In reply to comment #1)
> We might want to stop measuring entirely when people are in private mode since
> the cookie behavior is different.

I think that makes sense.
Given that nsCookieService::NotifyChanged already has two distinct topics "cookie-changed" and "private-cookie-changed", here is a first version that prefixes "third-party-cookie-{accepted, rejected}" with "private-" when in private mode.
Assignee: nobody → dteller
Attachment #772031 - Flags: feedback?(ehsan)
Comment on attachment 772031 [details] [diff] [review]
Use a different notification topic for third-party cookies in private mode

Review of attachment 772031 [details] [diff] [review]:
-----------------------------------------------------------------

It's unfortunate that we have to send notifications with different names in this case, but I can't think of a better way to do things given the observer interface.
Attachment #772031 - Flags: feedback?(ehsan) → feedback+
Same one, without the forgotten |const|.
Attachment #772031 - Attachment is obsolete: true
Attachment #772552 - Flags: review?(ehsan)
Attachment #772552 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/eaf3aed23ead
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.