88612 - Remove unsued cruft in the XPath classes

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

There is lots of unused functions in the XPath classes that just clutter up the 
code and increases download/compile time. Patch coming up that removes these 
functions.

It's not aimed in any way to improve the code that is actually used, just 
remove unused code. Though in a couple of instances my fingers just itched too 
much where I changed some code to be able to remove some function 
(NodeSet::remove being the only non-trivial example)

patch coming up...

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: attempt one

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'm actually having seconds thoughts on removing the NodeSet::remove functions 
since they are prtentionally usefull, however they're not used anywhere (with 
my changes to PredicateList::evaluatePredicates which are good anyway IMHO) 
so...

oppinions?

Comment 3

[Peter Van der Beken [:peterv]]

+    if ( idx >= 0 )
+       name.subString(0,idx, this->prefix);


Sigh.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

sorry, that code is pure copy'n'paste from setName so I didn't even look at it. 
But I'll fix it...

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: put back NodeSet::remove and removed the changes to PredicateList::evaluatePredicates

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

peterv pointed out that removing NodeSet::equals made it fallback to 
TxObject::equals. However we only use ::equals in the Map class for it's keys. 
However we only have Maps that key on Nodes so this should be safe.

Dang! I just realized that I havn't cleanup up the ExprResult classes :(
Separate patch for those coming up

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: cleanup ExprResults

Comment 8

[Peter Van der Beken [:peterv]]

r=peterv for 40791 and 40796

Comment 9

[Axel Hecht]

Are there any usecases for NodeSet::remove? or possible optims?
I would like that method to go, if there aren't any good reasons to keep it.

Axel

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I've left NodeSet::remove in there for two reasons:

1. It's currently used by PredicateList::evaluatePredicates (this is the main
   reason)
2. It is IMHO not an altogether bad function and could be usefull in the future

Comment 11

[Johnny Stenback (:jst)]

sr=jst

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

it's gone