886216 - Missing patch for bug 863475 in toolkit/crashreporter/breakpad-patches

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mike Hommey [:glandium]]

Note bug 886209 added a 12-sht-arm-exidx-define.patch that contains a fixup for bug 863475, that should be merged with the patch from bug 863475.

Comment 1

[Mike Hommey [:glandium]]

Patches for bug 836829, bug 883126 and bug 859745 are missing, too.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add missing breakpad patches

The Makefile.am change comes from re-running update-breakpad.sh against revision 1143 (update-breakpad.sh doing a filterdiff on Makefile*)

Comment 3

[Mike Hommey [:glandium]]

Note I haven't bothered merging patches when it made sense for them to be merged. I was more interested in getting update-breakpad.sh to get the same result as what is in the tree.

Comment 4

[Mike Hommey [:glandium]]

(merged as in folded)

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 782924 [details] [diff] [review]
Add missing breakpad patches

Review of attachment 782924 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, that's fine, as long as we have a record of what's in the tree I am okay at this point. I need to find time to get all this stuff upstream. :-/

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ddc199b1a6

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f5ddc199b1a6