886242 - [Settings] The icon will be changed to active state when you press a disabled item in settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #884142 +++

STR
====
1. Precondition : No SIM
2. Tester's Action : a. Launch Setting app
                     b. Press Call settings item
 
Actual result: the Call settings icon would be shown as active
Expected: the Call settings should not be shown as active
screenshot: see Bug 884142 Comment 5.


--
** For triage **

This should be a regression from 05c03cbf2a25e417116665273aa8ee809c48e3fc, Bug 866376, and was highlighted that should be fixed with Bug 884142. So nominated this as leo+.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10562

Pointer to Github pull-request

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 766583 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10562

Hi Arthur, 

This one-line CSS patch fixed the issue as we discussed.
Please help to have a review.

Thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 766583 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10562

Rudy, thank you for the effort! r=me.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia master,
4dbce25c5db4a9dd18c5ebe728a4bf434b933516

v1-train
1436e2778b90bd74635b0b94d1cf8ccb0d71b60c

--
Arthur,

Thanks for the review.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c

Comment 6

[Sarah Parsons]

Verified fixed on Leo Build ID: 20130717070237

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a7018b0
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
RIL Version: 01.01.00.019.158