886289 - Move SVGAnimatedNumber to WebIDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 766738 [details] [diff] [review]
Patch v1

>+
>+  nsSVGElement* GetParentObject() const
>+  {
>+    return mSVGElement;
>+  }

Is this used anywhere?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes.

Comment 4

[David Zbarsky (:dzbarsky)]

(In reply to Robert Longson from comment #2)
> Comment on attachment 766738 [details] [diff] [review]
> Patch v1
> 
> >+
> >+  nsSVGElement* GetParentObject() const
> >+  {
> >+    return mSVGElement;
> >+  }
> 
> Is this used anywhere?

It's called from the generated bindings code.

Comment 5

[David Zbarsky (:dzbarsky)]

Comment on attachment 766738 [details] [diff] [review]
Patch v1

Review of attachment 766738 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/nsSVGNumber2.h
@@ +83,5 @@
> +    }
> +    virtual void SetBaseVal(float aValue) MOZ_OVERRIDE
> +    {
> +      MOZ_ASSERT(NS_finite(aValue));
> +      mVal->SetBaseValue(aValue, mSVGElement);

You don't need this assertion assuming you used a restricted float in the WebIDL.  Also, is the WebIDL file missing from this patch?

::: content/svg/content/src/nsSVGNumberPair.h
@@ +93,5 @@
> +    }
> +    virtual void SetBaseVal(float aValue) MOZ_OVERRIDE
> +    {
> +      MOZ_ASSERT(NS_finite(aValue));
> +      mVal->SetBaseValue(aValue, mIndex, mSVGElement);

Ditto.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1 with webidl

Yeah, sorry about that.

As for the assertions, I'd rather keep them to make sure we notice if someone ends up calling those functions with non-finites.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a11558578574