Closed Bug 886291 Opened 11 years ago Closed 11 years ago

Fix styling issues on Make Details Navigation bar

Categories

(Webmaker Graveyard :: webmaker.org, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cassie, Assigned: kate)

References

Details

(Whiteboard: designQA)

Am looking at a make and there seem to be a couple bugs in the styling:

https://bboyinteractive.makes.org/thimble/your-own-3d-gallery

* The styles are affecting the nav bar css – that shouldn't happen. User shouldn't be able to make our navigation 3d....
* The nav bar width should grow responsively with the width of the user's page, ie. the blue background bar should extend across the entire make. I'm not liking that the page uses a horizontal scrollbar in the first place, but if it does, it should have the make details navigation bar sitting across the same width. Don't like that there is a blank space where the bar should be once you scroll right to see the rest of the make.
* "Made with Webmaker" should sit on the same line as the webmaker circle logo.
Assignee: nobody → dale
This is going to be fixed by bug 883488

The problem is a technical one of injecting a details bar into a webpage. We're going to try an iframe solution and publish two versions, one is a pure page, the other is a details page with an iframe that the pure page is set to. No CSS tweaks are going to completely solve this. As soon as someone does some element css without a classname it'll break. I don't think we expected just how often people do this.

I am not quite sure what you mean about the second point. I don't see a horizontal scrollbar.
Assignee: dale → nobody
(In reply to Scott [:thecount] Downe from comment #1)
> This is going to be fixed by bug 883488

Sweet!

> I am not quite sure what you mean about the second point. I don't see a
> horizontal scrollbar.

Here are screenshots of what I'm seeing: 
* Horizonatal scroll bar: http://cl.ly/Pp2A
* No top bar blue background and Remix button not aligned right: http://cl.ly/PpH1
Depends on: 883488
Should be fixed now.

I remixed it here: https://scott.makes.org/thimble/your-own-3d-gallery

On a republish of the original it should be fixed.
looks like everything's fixed, can we close this ticket?
Assignee: nobody → kate
Status: NEW → ASSIGNED
Yep!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.