Closed Bug 886454 Opened 7 years ago Closed 7 years ago

Update check says "up to date" for out of date versions on unsupported OS versions - Port bug 843497 to Thunderbird

Categories

(Thunderbird :: Installer, defect)

x86
Windows 2000
defect
Not set

Tracking

(thunderbird24+ fixed)

RESOLVED FIXED
Thunderbird 24.0
Tracking Status
thunderbird24 + fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #843497 +++

This is to port bug 843497 which gives us an out of date prompt, that we might want for end of ESR in future.
Attached patch The fix (obsolete) — Splinter Review
This is a straight copy of the Firefox code - attachment 765826 [details] [diff] [review].
Attachment #766860 - Flags: review?(mconley)
Assignee: nobody → mbanner
16:23 (mconley) Standard8: so, gAppUpdater.update.detailsURL - when would that be undefined?
16:23 (mconley) Standard8: not sure i'm a big fan of the idea of having a Learn More... with the possibility that it doesn't take the user anywhere on clicking
16:23 (mconley) that'd be crazy-frustrating.
16:26 wsm has left IRC (Ping timeout)
16:28 (mconley) Standard8: everything else looks OK - but that's the only thing that kinda concerns me about this patch
Attached patch The fix v2Splinter Review
Updated patch with r=mconley over irc.
Attachment #766878 - Flags: review+
https://hg.mozilla.org/comm-central/rev/f9daa00af61d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Attachment #766860 - Attachment is obsolete: true
Attachment #766860 - Flags: review?(mconley)
You need to log in before you can comment on or make changes to this bug.