Last Comment Bug 886454 - Update check says "up to date" for out of date versions on unsupported OS versions - Port bug 843497 to Thunderbird
: Update check says "up to date" for out of date versions on unsupported OS ver...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Installer (show other bugs)
: unspecified
: x86 Windows 2000
: -- normal (vote)
: Thunderbird 24.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on: 843497
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-24 12:24 PDT by Mark Banner (:standard8)
Modified: 2013-06-24 14:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed


Attachments
The fix (2.80 KB, patch)
2013-06-24 13:20 PDT, Mark Banner (:standard8)
no flags Details | Diff | Review
The fix v2 (2.87 KB, patch)
2013-06-24 13:54 PDT, Mark Banner (:standard8)
standard8: review+
Details | Diff | Review

Description Mark Banner (:standard8) 2013-06-24 12:24:10 PDT
+++ This bug was initially created as a clone of Bug #843497 +++

This is to port bug 843497 which gives us an out of date prompt, that we might want for end of ESR in future.
Comment 1 Mark Banner (:standard8) 2013-06-24 13:20:01 PDT
Created attachment 766860 [details] [diff] [review]
The fix

This is a straight copy of the Firefox code - attachment 765826 [details] [diff] [review].
Comment 2 Mike Conley (:mconley) - (needinfo me!) 2013-06-24 13:28:44 PDT
16:23 (mconley) Standard8: so, gAppUpdater.update.detailsURL - when would that be undefined?
16:23 (mconley) Standard8: not sure i'm a big fan of the idea of having a Learn More... with the possibility that it doesn't take the user anywhere on clicking
16:23 (mconley) that'd be crazy-frustrating.
16:26 wsm has left IRC (Ping timeout)
16:28 (mconley) Standard8: everything else looks OK - but that's the only thing that kinda concerns me about this patch
Comment 3 Mark Banner (:standard8) 2013-06-24 13:54:06 PDT
Created attachment 766878 [details] [diff] [review]
The fix v2

Updated patch with r=mconley over irc.
Comment 4 Mark Banner (:standard8) 2013-06-24 13:56:13 PDT
https://hg.mozilla.org/comm-central/rev/f9daa00af61d

Note You need to log in before you can comment on or make changes to this bug.